fix: replace misleading echo hint with plain file path in --quick-add#36
Merged
Conversation
The previous hint suggested appending a second custom_hosts= assignment to the file, which conflicts with the existing definition and creates duplicates on repeated use. Replace it with the file path and a plain instruction to edit the custom_hosts variable directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous hint suggested running:
This appends a second
custom_hosts=assignment to a file that already has one. While it works when sourced, it's messy and creates duplicate entries each time it's run.Replace it with the file path and a plain instruction to edit the
custom_hostsvariable directly — the right approach regardless of whether the user has a single-line or multi-line continuation definition.