Open
Conversation
edrosten
reviewed
Jan 5, 2022
| echo | ||
| changequote([,]) | ||
|
|
||
| AC_DEFINE([GVARS3_HAVE_TOON], [], [Description]) |
Owner
There was a problem hiding this comment.
these ought to be defined, though you need to have TooN installed and accessible before running ./configure for gvars
Author
There was a problem hiding this comment.
I did try to remove that patch, but then I get an error when the build system runs "autoheader", see extract from the build log:
dh binary
dh_update_autotools_config
dh_autoreconf
configure.ac:70: warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE call detected in body
./lib/autoconf/lang.m4:199: AC_LANG_CONFTEST is expanded from...
./lib/autoconf/general.m4:2823: _AC_COMPILE_IFELSE is expanded from...
./lib/autoconf/general.m4:2839: AC_COMPILE_IFELSE is expanded from...
configure.ac:70: the top level
configure.ac:71: warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE call detected in body
./lib/autoconf/lang.m4:199: AC_LANG_CONFTEST is expanded from...
./lib/autoconf/general.m4:2823: _AC_COMPILE_IFELSE is expanded from...
./lib/autoconf/general.m4:2839: AC_COMPILE_IFELSE is expanded from...
configure.ac:71: the top level
configure.ac:92: warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE call detected in body
./lib/autoconf/lang.m4:199: AC_LANG_CONFTEST is expanded from...
./lib/autoconf/general.m4:2823: _AC_COMPILE_IFELSE is expanded from...
./lib/autoconf/general.m4:2839: AC_COMPILE_IFELSE is expanded from...
configure.ac:92: the top level
configure.ac:108: warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE call detected in body
./lib/autoconf/lang.m4:199: AC_LANG_CONFTEST is expanded from...
./lib/autoconf/general.m4:2823: _AC_COMPILE_IFELSE is expanded from...
./lib/autoconf/general.m4:2839: AC_COMPILE_IFELSE is expanded from...
configure.ac:108: the top level
configure.ac:120: warning: AC_LANG_CONFTEST: no AC_LANG_SOURCE call detected in body
./lib/autoconf/lang.m4:199: AC_LANG_CONFTEST is expanded from...
./lib/autoconf/general.m4:2823: _AC_COMPILE_IFELSE is expanded from...
./lib/autoconf/general.m4:2839: AC_COMPILE_IFELSE is expanded from...
configure.ac:120: the top level
configure.ac:291: warning: AC_OUTPUT should be used without arguments.
configure.ac:291: You should run autoupdate.
autoheader: warning: missing template: GVARS3_HAVE_TOON
autoheader: warning: Use AC_DEFINE([GVARS3_HAVE_TOON], [], [Description])
autoheader: warning: missing template: GVARS3_HAVE_TOON2
autoreconf: error: /usr/bin/autoheader failed with exit status: 1
dh_autoreconf: error: autoreconf -f -i returned exit code 1
make: *** [debian/rules:4: binary] Error 25
So even though I can of course keep a Debian-specific patch, I stand by my merge request :-)
Owner
There was a problem hiding this comment.
OK, I'll look into it. I think this is to do with some of the more advanced integration for automake? I've not used automake here, only autoconf, so the usual way of running is:
autoconf
./configure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.