Feature: Select author by name or email#2
Open
nwallace wants to merge 4 commits intoedsinclair:masterfrom
Open
Feature: Select author by name or email#2nwallace wants to merge 4 commits intoedsinclair:masterfrom
nwallace wants to merge 4 commits intoedsinclair:masterfrom
Conversation
Cucumber tests rely on Test::Unit assertions, but that wasn't specified as a dependency. Additionally, the cucumber test setup was not correctly setting up the temporary git repository due to a rogue `&&`.
nwallace
force-pushed
the
feature/select-by-name-or-email
branch
from
29b2107 to
4711f38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I work with someone who has the same initials as me (even the same middle initial!). The only way we can use this is if we put in his middle initial but omit mine -- then he can be chosen with "nmw" and me with "nw". This patch extends the selection logic to also match on name (first or last) or email address. I think using the person's first name is the most natural way to select an author, but the other options are there in case of conflicts. Initials still work as well, of course.
I had to base this pull request off my other pull request, since the tests won't run otherwise, but if that's a problem, I can rebase and separate those commits.
Thanks!