Bug #218, respond with 4xx HTTP error codes, not 500 #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hi @eduardoboucas, The Travis-CI build fails because of a pre-existing If you ignore that, the unit tests etc. pass fine! I hope that helps, Nick |
Owner
|
I must say I'm not sure I like the idea of using 404 for missing config properties. As you pointed out, I think a 400 would be more appropriate. Other than that, it looks great. Thanks for this! |
caiopavanelli
pushed a commit
to caiopavanelli/staticman
that referenced
this pull request
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @eduardoboucas,
I've implemented a fix/enhancement for the #218 issue.
You'll see that it uses several sources to try to determine the HTTP status code —
payload.rawError.code, thenpayload.rawError._smErrorCode.The possible HTTP status codes are:
404— REST purists may not agree with how I propose using this for "missing" config-type errors (some/all of these could be changed to400I suppose);403— one of the GitHub responses I think (Investigate alternative commenting ...? Staticman nfreear/nfreear-blog#32 (comment));400— most of the "invalid" request/ config-type responses;500— fallback, unknown error)200— success;I hope this helps.
Best wishes,
Nick