Use gameLeftPanel as gameRightPanel#974
Open
EgzoT wants to merge 2 commits intoedubart:masterfrom
EgzoT:EgzoT-use_gameLeftPanel_as_gameRightPanel
Open
Use gameLeftPanel as gameRightPanel#974EgzoT wants to merge 2 commits intoedubart:masterfrom EgzoT:EgzoT-use_gameLeftPanel_as_gameRightPanel
EgzoT wants to merge 2 commits intoedubart:masterfrom
EgzoT:EgzoT-use_gameLeftPanel_as_gameRightPanel
Conversation
Closed
|
I have extra right panel on my otclient how can i add that panel into this code? |
lucasromagnoli
approved these changes
Mar 24, 2020
HalfAway
approved these changes
Apr 24, 2020
Collaborator
|
This is a good start at which we can actually support multiple containers. I'm looking to merging this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's provide to use gameLeftPanel (if it's ON) like gameRightPanel, by using function addToPanels().
When gameRightPanel is full:

When in gameRightPanel one window is resized (now windows it's moved to gameLeftPanel, normal it's would be removed):

New functions:
[modules.game_interface] addToPanels(
<UIWidget>) - they set uiminiwindow in gameRightPanel or in gameLeftPanel (according on free place) priority gameRightPanel [function may set uiminiwindow to gameLeftPanel only when it's ON], additional they moved (if find free place in gameRightPanel or gameLeftPanel) window when we add other uiminiwindow or resize one from them when uiminiwindowcontainer is full (instead remove) to other Panel.UIMiniWindowContainer:getEmptySpaceHeight() - return height of UIMiniWindowContainer without windows (uiminiwindow), who we may set to other windows.
New signals (signalcall):
UIMiniWindowContainer.onRemoveFromContainer [
<UIWidget>] - return UIWidget who want to be removed (before deleted who provide to set operation to stopped deleted this UIWidget [change parent]) from UIMiniWindowContainer (by UIMiniWindowContainer:fitAll()).