fix: add trailing slash to retire_certs_s3_for_user URL pattern#1206
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a routing mismatch for the certificates retirement per-user endpoint by updating the Django URL pattern to include a trailing slash (to match a client that always appends /), and bumps the package version / changelog accordingly.
Changes:
- Add trailing slash to
retire_certs_s3_for_userURL route and update the corresponding test request path. - Bump package version to
7.7.0. - Add a
7.7.0changelog entry (but the current diff also introduces accidental duplicate/stray changelog content that should be removed).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
edx_arch_experiments/certificates/urls.py |
Updates API route for the per-user retirement endpoint to include a trailing slash. |
edx_arch_experiments/certificates/tests/test_views.py |
Updates the test POST URL to match the new trailing-slash route. |
edx_arch_experiments/__init__.py |
Version bump to 7.7.0. |
CHANGELOG.rst |
Adds 7.7.0 release notes, but also accidentally adds duplicated legacy entries that should be removed. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Akanshu-2u
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The retire_certs_s3_for_user URL was missing a trailing slash. Tubular's get_api_url() always appends a trailing slash, so the POST request hit .../retire_certs_s3_for_user/ which Django redirected (301) to a GET, returning 404 since no GET handler exists.
Changes
added trailing slash to the URL pattern in certificates/urls.py.
Merge checklist:
Check off if complete or not applicable:
JIRA ticket: