feat: enable intergrated channel pipeline - sync_tpa_budget_group - #421
Open
jono-booth wants to merge 1 commit into
Open
feat: enable intergrated channel pipeline - sync_tpa_budget_group#421jono-booth wants to merge 1 commit into
jono-booth wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the enterprise third-party-auth pipeline insertion logic to include an additional pipeline step intended to sync the TPA budget group for integrated channel support.
Changes:
- Added
channel_integrations.integrated_channel.pipeline.sync_tpa_budget_groupto the additional enterprise social-auth pipeline elements.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
1036
to
1039
| additional_elements = ( | ||
| 'enterprise.tpa_pipeline.handle_enterprise_logistration', | ||
| 'channel_integrations.integrated_channel.pipeline.sync_tpa_budget_group', | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Wires a new login-time step into the SSO pipeline:
channel_integrations.integrated_channel.pipeline.sync_tpa_budget_group, appended to theadditional_elementstuple ininsert_enterprise_pipeline_elements(openedx/features/enterprise_support/api.py), right afterenterprise.tpa_pipeline.handle_enterprise_logistration.This is Stage 3 of a staged rollout for ENT-12084 (Learner Credit Subsidies: restrict Skillsoft learners to the budget matching the org they logged in under). The function itself lives in
enterprise-integrated-channels(PR openedx/enterprise-integrated-channels#190) and, once wired in here, checks a waffle switch (enable_tpa_org_group_login_sync, default off) before doing anything - so merging and deploying this PR causes no behavior change for any customer on its own. Its only purpose is to prove the new pipeline entry resolves and imports cleanly on every SSO login. See that repo'sdocs/how-tos/onboard_skillsoft_org_budget.rstfor the full mechanism.Affected user role: none directly (Operator-only, behind a flag that stays off until a later, separate rollout stage).
Supporting information
pipeline.sync_tpa_budget_groupand the waffle switch this PR referencesTesting instructions
sync_tpa_budget_grouporenterprise_support.No canary/functional test of the actual budget-group sync is possible from this PR alone; that requires the switch to be enabled and at least one org mapped, which happens in a later rollout stage.
Deadline
None.
Other information
enterprise-integrated-channelsmust be pinned to>=0.1.67(published from feat: auto-assign TPA org learners to their orgs Learner Credit budget openedx/enterprise-integrated-channels#190) before this PR is deployed. As of this branch,requirements/edx/base.txtstill pinsenterprise-integrated-channels==0.1.18, which does not containchannel_integrations.integrated_channel.pipeline. Deploying this change ahead of that pin bump would make the dotted-path pipeline entry unresolvable at Django startup, breaking SSO login for every customer, not just Skillsoft. The pin bump should land and be verified as its own prior PR/deploy (make upgrade-package package=enterprise-integrated-channels) before this one merges.additional_elementsfully reverts the change.