Skip to content

Upgrade to Django 5.2 - #423

Open
dianakhuang wants to merge 3 commits into
release-ulmofrom
diana/django52
Open

Upgrade to Django 5.2#423
dianakhuang wants to merge 3 commits into
release-ulmofrom
diana/django52

Conversation

@dianakhuang

Copy link
Copy Markdown

No description provided.

Bumps the constraint so that upgrades can bring us to Django 5.2.
pip 25 and pip-tools 7.5.1 aren't compatible and
causes errors.
Copilot AI lite review requested due to automatic review settings August 11, 2026 19:12

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts dependency constraints and CI configuration in preparation for a Django upgrade, and updates the pinned pip-tools version used for requirements management.

Changes:

  • Bumped pip-tools from 7.5.1 to 7.6.0 in the pip-tools requirements set.
  • Relaxed the Django upper-bound constraint from <5.0 to <6.0.
  • Removed the Django 5.2 job from the unit-test matrix (leaving only the pinned Django run).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
requirements/pip-tools.txt Updates the pinned pip-tools version used to manage/compile requirements.
requirements/constraints.txt Relaxes the Django upper-bound constraint (and updates the accompanying comment block).
.github/workflows/unit-tests.yml Updates CI matrix to no longer run tests against Django 5.2.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines +22 to +24
# Date: 2026-08-11
# Stay on LTS version
Django<6.0
Comment on lines +22 to +24
# Date: 2026-08-11
# Stay on LTS version
Django<6.0
Comment on lines 24 to 25
django-version:
- "pinned"
packaging==25.0
# via build
pip-tools==7.5.1
pip-tools==7.6.0
Copilot AI review requested due to automatic review settings August 11, 2026 19:19

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Suppressed comments (3)

requirements/constraints.txt:24

  • requirements/constraints.txt already includes -c common_constraints.txt, and requirements/common_constraints.txt currently constrains Django to Django<6.0 (line 19). Duplicating Django<6.0 here adds a maintenance burden and risks the two constraints diverging; it also contradicts the previous intent to keep this kind of pin in the common constraints file.
# Date: 2026-08-11
# Stay on LTS version
Django<6.0

requirements/pip-tools.txt:13

  • requirements/pip-tools.txt has been updated to pip-tools==7.6.0, but requirements/edx/development.txt still pins pip-tools==7.5.1 (see requirements/edx/development.txt:1462) while also indicating it is sourced “via -r requirements/pip-tools.txt”. This mismatch is likely to break dependency installs (conflicting pins) and suggests the compiled requirements weren’t regenerated after the bump.
pip-tools==7.6.0

.github/workflows/unit-tests.yml:25

  • The PR is titled “Upgrade to Django 5.2”, but the unit test matrix no longer includes a Django 5.2 job. With only django-version: pinned, CI won’t exercise the upgrade target explicitly, making regressions easier to miss.
        django-version:
          - "pinned"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants