Upgrade to Django 5.2 - #423
Open
dianakhuang wants to merge 3 commits into
Open
Conversation
Bumps the constraint so that upgrades can bring us to Django 5.2.
pip 25 and pip-tools 7.5.1 aren't compatible and causes errors.
There was a problem hiding this comment.
Pull request overview
Adjusts dependency constraints and CI configuration in preparation for a Django upgrade, and updates the pinned pip-tools version used for requirements management.
Changes:
- Bumped
pip-toolsfrom 7.5.1 to 7.6.0 in thepip-toolsrequirements set. - Relaxed the Django upper-bound constraint from
<5.0to<6.0. - Removed the Django 5.2 job from the unit-test matrix (leaving only the pinned Django run).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| requirements/pip-tools.txt | Updates the pinned pip-tools version used to manage/compile requirements. |
| requirements/constraints.txt | Relaxes the Django upper-bound constraint (and updates the accompanying comment block). |
| .github/workflows/unit-tests.yml | Updates CI matrix to no longer run tests against Django 5.2. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+22
to
+24
| # Date: 2026-08-11 | ||
| # Stay on LTS version | ||
| Django<6.0 |
Comment on lines
+22
to
+24
| # Date: 2026-08-11 | ||
| # Stay on LTS version | ||
| Django<6.0 |
Comment on lines
24
to
25
| django-version: | ||
| - "pinned" |
| packaging==25.0 | ||
| # via build | ||
| pip-tools==7.5.1 | ||
| pip-tools==7.6.0 |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Suppressed comments (3)
requirements/constraints.txt:24
requirements/constraints.txtalready includes-c common_constraints.txt, andrequirements/common_constraints.txtcurrently constrains Django toDjango<6.0(line 19). DuplicatingDjango<6.0here adds a maintenance burden and risks the two constraints diverging; it also contradicts the previous intent to keep this kind of pin in the common constraints file.
# Date: 2026-08-11
# Stay on LTS version
Django<6.0
requirements/pip-tools.txt:13
requirements/pip-tools.txthas been updated topip-tools==7.6.0, butrequirements/edx/development.txtstill pinspip-tools==7.5.1(seerequirements/edx/development.txt:1462) while also indicating it is sourced “via -r requirements/pip-tools.txt”. This mismatch is likely to break dependency installs (conflicting pins) and suggests the compiled requirements weren’t regenerated after the bump.
pip-tools==7.6.0
.github/workflows/unit-tests.yml:25
- The PR is titled “Upgrade to Django 5.2”, but the unit test matrix no longer includes a Django 5.2 job. With only
django-version: pinned, CI won’t exercise the upgrade target explicitly, making regressions easier to miss.
django-version:
- "pinned"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.