Implement Pdu::TryFrom<&[u8]>. - #22
Open
stefand wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Hi! Did you have a chance to look at this pull request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's the promised Pdu::from implementation. I have used it to parse SMS from the storage of Mocor and MAUI dumbphones.
When reviewing, have a look in particular of the handling of the validity_period octet. Online sources I ran into suggest that it is optional, but I found that the octet is always present (i.e., I'm incrementing the offset unconditionally), its just sometimes 0. I don't care about the particular value for my use case.
Yeah, tests would be nice, but this is a hobby project and I may or may not get to it at some point.