Repository navigation
[ci] security hardening + Claude-gated Dependabot auto-merge - #3
Merged
Merged
Conversation
CodeQL flagged actions/missing-workflow-permissions: without a permissions block the jobs inherit the repo's default GITHUB_TOKEN scope. These jobs only check out and test code, so contents: read is all they need. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Reviewed. The PR adds a top-level Optional, not blocking: the actionlint install uses No issues found. |
The concurrency group was workflow-level and keyed on the PR number, so the issue_comment event fired by Claude's review comment started a new run in the same group and cancelled the review that had just finished (green review, red-cancelled job). Scope the group to the review job only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- claude-review.yml: review moved out of claude.yml into its own pull_request-only workflow, so a comment-triggered run can never post a skipped "review" check over a failing one. Reviews Dependabot PRs too (allowed_bots), treats PR text and changelogs as untrusted, and fails unless Claude's summary ends with "Verdict: PASS <head sha>". A Dependabot PR that edits this workflow, or arrives without the token, fails closed. - dependabot-automerge.yml: queues auto-merge for package patch/minor and GitHub Actions bumps (fetch-metadata pinned by SHA); everything else is left for a human and has auto-merge switched off. - claude.yml now only answers owner @claude mentions; action pinned by SHA. Reviewed by bug-hunter + security-auditor agents before push. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
CI installed ruff unpinned, so a release that widened the default rule set turned lint red on code nobody had touched (I001 and friends). Pin ruff 0.16.2 and, where the repo relied on the implicit default, write the old default down (E4, E7, E9, F) so an upgrade cannot silently change the contract. Same fix claude-craft-kit took in August. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
effecet
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeQL flagged
actions/missing-workflow-permissions: without apermissions:block, CI jobs inherit the repo's defaultGITHUB_TOKENscope. These jobs only check out and test code, socontents: readis all they need. (claude.ymlalready declares per-job permissions.)🤖 Generated with Claude Code