Repository navigation
Fix DELETE /v1/note/share to parse ID from JSON request body - #65
Conversation
…N request body instead of only query parameters. The endpoint used `http_utils.GetUIntFormValue` which ignores JSON payloads. Added logic to parse the request body and fallback to unmarshaling JSON to retrieve `id` or `noteId`. Co-authored-by: egeozcan <185294+egeozcan@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
The PR's float64 conversion truncated 1.5 to 1 and wrapped negative or huge values onto other notes, read an unbounded body, and ignored the Content-Type. Decode json.Number through parseUintStrict instead, cap the body, only look when the request is JSON, and document the body form. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Review findings, all fixed in the pushed commit:
|
Acknowledged. I've fetched the changes pushed by the user and confirmed the tests are passing. |
…N request body instead of only query parameters. The endpoint used `http_utils.GetUIntFormValue` which ignores JSON payloads. Added logic to parse the request body and fallback to unmarshaling JSON to retrieve `id` or `noteId`. Co-authored-by: egeozcan <185294+egeozcan@users.noreply.github.com>
Fix DELETE /v1/note/share to correctly extract the note ID from a JSON request body instead of only query parameters.
The endpoint used
http_utils.GetUIntFormValuewhich ignores JSON payloads. Added logic to parse the request body and fallback to unmarshaling JSON to retrieveidornoteId.PR created automatically by Jules for task 3263962093540364728 started by @egeozcan