Skip to content

added validation for numbers when creating a cell with numbers #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nicklassigurdh wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added validation for numbers when creating a cell with numbers #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions __test__/formatters/cells/generatorNumberCell.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,15 @@
import generatorNumberCell from '../../../src/formatters/cells/generatorNumberCell';

export const expectedXML = '<c r="A1"><v>1000</v></c>';
export const expectedErrorXML = '<c r="A1"><v>NaN</v></c>';

describe('Cell of type Number', () => {
it('Should create a new xml markup cell', () => {
expect(generatorNumberCell(0, 1000, 1)).toBe(expectedXML);
});

it('Should create a new xml markup cell with NaN when there is not a number', () => {
expect(generatorNumberCell(0, '</v></c><c><v>text', 1)).toBe(expectedErrorXML);
});
});

6 changes: 5 additions & 1 deletion src/formatters/cells/generatorNumberCell.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
import generatorCellNumber from '../../commons/generatorCellNumber';

export default (index, value, rowIndex) => (`<c r="${generatorCellNumber(index, rowIndex)}"><v>${value}</v></c>`);
export default (index, value, rowIndex) => (`<c r="${generatorCellNumber(index, rowIndex)}"><v>${validateNumber(value)}</v></c>`);

const validateNumber = (value) => {
return (isNaN(value))? 'NaN' : value;
}