Skip to content

Add packed join node and positioned-index abstractions - #969

Draft
ezrosent wants to merge 2 commits into
codex/dvo-ordering-policyfrom
codex/packed-join-abstractions
Draft

Add packed join node and positioned-index abstractions#969
ezrosent wants to merge 2 commits into
codex/dvo-ordering-policyfrom
codex/packed-join-abstractions

Conversation

@ezrosent

Copy link
Copy Markdown
Contributor

Stacked on the DVO policy PR.

This introduces the reusable pieces of the packed generic-join design without switching the executor over:

  • arena-packed trie nodes and cursors
  • stable positioned-index APIs
  • compatibility wrappers that keep the existing executor behavior unchanged

The executor integration remains isolated in #959.

Validation:

  • cargo test -p egglog-core-relations
  • cargo fmt --check
  • cargo clippy -p egglog-core-relations --all-targets -- -D warnings

@codecov-commenter

codecov-commenter commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.12067% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.14%. Comparing base (f001a63) to head (80431f5).

Files with missing lines Patch % Lines
core-relations/src/free_join/packed_trie.rs 97.76% 19 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                      @@
##           codex/dvo-ordering-policy     #969      +/-   ##
=============================================================
+ Coverage                      86.82%   87.14%   +0.31%     
=============================================================
  Files                             95       96       +1     
  Lines                          30659    31667    +1008     
=============================================================
+ Hits                           26620    27596     +976     
- Misses                          4039     4071      +32     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq

codspeed-hq Bot commented Jul 30, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 37 untouched benchmarks
⏩ 227 skipped benchmarks1


Comparing codex/packed-join-abstractions (80431f5) with codex/dvo-ordering-policy (f001a63)

Open in CodSpeed

Footnotes

  1. 227 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@ezrosent
ezrosent force-pushed the codex/packed-join-abstractions branch from f55feee to 80431f5 Compare July 30, 2026 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants