Unify sequence-container maintenance - #978
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## codex/inline-containers-04-infrastructure #978 +/- ##
============================================================================
Coverage ? 87.60%
============================================================================
Files ? 98
Lines ? 37673
Branches ? 0
============================================================================
Hits ? 33002
Misses ? 4671
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merging this PR will degrade performance by 2%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | tests[python_array_optimize] |
1.1 s | 1.3 s | -14.46% |
| ❌ | Simulation | tests[eggcc-extraction] |
1.4 s | 1.6 s | -14.02% |
| ❌ | Simulation | tests[typeinfer] |
114.9 ms | 129.5 ms | -11.32% |
| ❌ | Simulation | tests[eggcc-2mm] |
7.7 s | 8.5 s | -9.46% |
| ❌ | Simulation | tests[luminal-llama] |
504.4 ms | 554.5 ms | -9.04% |
| ❌ | Simulation | tests[repro-665-set-union] |
602 ms | 635.3 ms | -5.25% |
| ⚡ | Simulation | rust_rule_insert_loop[ops1000_funcs0] |
632.8 µs | 583.5 µs | +8.46% |
| ⚡ | Simulation | rust_rule_insert_loop[ops1000_funcs2000] |
912.3 µs | 844.8 µs | +8% |
| ⚡ | Simulation | rust_rule_insert_loop[ops1000_funcs200] |
671.1 µs | 623.1 µs | +7.7% |
| ⚡ | Simulation | rust_rule_insert_loop[ops100000_funcs2000] |
50 ms | 46.5 ms | +7.68% |
| ⚡ | Simulation | rust_rule_insert_loop[ops100000_funcs200] |
50.3 ms | 47.2 ms | +6.51% |
| ⚡ | Simulation | rust_rule_insert_loop[ops100000_funcs0] |
50.3 ms | 47.2 ms | +6.5% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing codex/inline-containers-05-unified-maintenance (14d3f72) with main (716c320)2
Footnotes
-
227 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
codex/inline-containers-04-infrastructure(9ee921c) during the generation of this report, somain(716c320) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
14d3f72 to
ea2856a
Compare
Summary
MaintenanceTableinterface shared by relations and sequence-backed containers.TableIdnamespace and schedule them through the same dependency graph, buffers, notifications, merge loop, and rebuild traversal.Stack
Draft, stacked on #977. This is PR 5 of 12 in the sequence-backed container stack.
Validation
Validated on the complete 12-commit stack:
cargo nextest run --workspace: 1,362 tests passedcargo test --workspace --doccargo clippy --workspace --all-targets -- -D warningscargo fmt --all -- --check