Return optional<int> from segment tree binary search methods#157
Merged
Return optional<int> from segment tree binary search methods#157
Conversation
Co-authored-by: ei1333 <11004413+ei1333@users.noreply.github.com>
Co-authored-by: ei1333 <11004413+ei1333@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix return value of find_first in segment tree binary search
Return optional<int> from segment tree binary search methods
Nov 20, 2025
ei1333
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
find_firstandfind_lastmethods returned the same value (nand-1respectively) both when no position satisfied the condition and when boundary conditions were met, creating ambiguity for callers.Changes
inttooptional<int>forfind_firstandfind_lastin:structure/segment-tree/segment-tree.hppstructure/segment-tree/lazy-segment-tree.hppnulloptwhen condition is never satisfied or parameters are out of boundsUsage
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.