Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR upgrades two key HEP data model packages: edm4hep from 0.99.4 to 1.0 and podio from 1.6 to 1.7. The changes incorporate upstream Spack package definitions through cherry-picked commits and update the default version constraints in the build environment configuration.
Changes:
- Add three cherry-pick commits from spack/spack-packages to incorporate new package versions and python freethreading conflict constraints
- Update edm4hep version requirement from '@0.99.4' to '@1.0' in packages.yaml
- Update podio version requirement from '@1.6' to '@1.7' in packages.yaml
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| spack-packages.sh | Adds three cherry-pick commits (7e4068a, 208b3c4, 9ba7aca) with proper documentation for freethreading conflicts, podio 1.7, and edm4hep 1.0 |
| spack-environment/packages.yaml | Updates version constraints for edm4hep and podio packages to match the new versions |
0a0d421 to
401748c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Needs:
This PR upgrades
edm4hepto 1.0 andpodioto 1.7.