Open
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the Spack package manager version from v1.0.2 to v1.1.0 to incorporate the latest upstream changes and improvements from the Spack project.
- Updates the
SPACK_VERSIONvariable to reference the v1.1.0 release - Maintains existing cherry-picks for custom patches
- No breaking changes or behavior modifications
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wdconinc
force-pushed
the
spack-1.1.0
branch
from
d83f05f to
28b4f41
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as off-topic.
This comment was marked as off-topic.
wdconinc
force-pushed
the
spack-1.1.0
branch
from
28b4f41 to
6893049
Compare
wdconinc
commented
Nov 19, 2025
wdconinc
force-pushed
the
spack-1.1.0
branch
8 times, most recently
from
8cc24d5 to
8d3576f
Compare
13 tasks
wdconinc
force-pushed
the
spack-1.1.0
branch
from
8d3576f to
515068c
Compare
Removed llvm package requirement for gold.
Added concretizer configuration for unified LLVM handling.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
wdconinc
force-pushed
the
spack-1.1.0
branch
from
1893272 to
ba1bdb3
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
docs/spack-environment.md:156
- This snippet is labeled “From spack.sh”, but the
SPACK_CHERRYPICKSlist here doesn’t matchspack.sh(which includes an additional hash). Update the snippet to match the currentspack.shcontents or reword it as an example so it doesn’t become misleading.
SPACK_VERSION="v1.1.0"
SPACK_CHERRYPICKS=$(cat <<- EOF
09f75ee426a2e05e0543570821582480ff823ba5
a462612b64e97fa7dfe461c32c58553fd6ec63c5
EOF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Needs:
preferandrequiresforpackages:all#48This PR upgrades spack to v1.1.0, https://github.com/spack/spack/releases/tag/v1.1.0.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.