Skip to content

Benchmarks for nhcal#168

Draft
MSieczczynski wants to merge 58 commits intomasterfrom
pr/nhcal
Draft

Benchmarks for nhcal#168
MSieczczynski wants to merge 58 commits intomasterfrom
pr/nhcal

Conversation

@MSieczczynski
Copy link
Contributor

Briefly, what does this PR introduce?

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

Does this PR change default behavior?

@MSieczczynski MSieczczynski requested a review from lkosarz June 25, 2025 16:27
@MSieczczynski MSieczczynski changed the title Adding benchmark sampF for nhcal. Benchmarks for nhcal Jun 25, 2025
@veprbl
Copy link
Member

veprbl commented Jan 15, 2026

Token rotated, pipeline should work again.

@lkosarz
Copy link
Contributor

lkosarz commented Mar 6, 2026

Looks like we need some help with this. Everything worked fine with eic_xl container, but the switch to eic_cl introduced strange issues. Could you take a look?

One of the jobs seems to be missing output files:

2026-02-11T15:42:36.549450Z 01E MissingOutputException in rule nhcal_dimuon_photoproduction_presimulate in file /builds/EIC/benchmarks/detector_benchmarks/benchmarks/nhcal_dimuon_photoproduction/Snakefile, line 1:
2026-02-11T15:42:36.549459Z 01E Job 1  completed successfully, but some output files are missing. Missing files after 5 seconds. This might be due to filesystem latency. If that is the case, consider to increase the wait time with --latency-wait:
2026-02-11T15:42:36.549461Z 01E sim_input/DiMuon_ep_18x275GeV.1.hepmc3

other issue may be related to the update of geometry. We added extra plastic slice in the front. Can it cause this error?

 2026-02-11T15:44:55.595238Z 01E slice_idx=4 actual=3 expected=3
2026-02-11T15:44:55.595242Z 01E types: actual=i expected=i
2026-02-11T15:44:55.595279Z 01E comparison: 0
2026-02-11T15:44:55.595280Z 01E hex: actual=0x3 expected=0x30x561f96248ff8
2026-02-11T15:44:55.595282Z 01E type: l
2026-02-11T15:44:55.598929Z 01E [WARN] getPlasticThicknessCM: cell is not plastic (slice mismatch) (cellID=f000900808271)

This is the piece of code that causes it:

        int actual_value = dec->get(cid, slice_idx);
        cerr << "slice_idx=" << slice_idx << " actual=" << actual_value 
            << " expected=" << plastic_slice_value << "\n";
        cerr << "types: actual=" << typeid(actual_value).name() 
            << " expected=" << typeid(plastic_slice_value).name() << "\n";
        cerr << "comparison: " << (actual_value != plastic_slice_value) << "\n";
        cerr << "hex: actual=0x" << hex << actual_value 
            << " expected=0x" << plastic_slice_value << dec << "\n";
        cerr << "type: " << typeid(dec->get(cid, slice_idx)).name() << "\n";
        if (actual_value != plastic_slice_value)
            throw runtime_error("cell is not plastic");

or this one:

try {
        if (!decoder) throw std::runtime_error("decoder==nullptr");
        if (decoder->get(cid, slice_index) != plastic_slice_value)
            throw std::runtime_error("cell is not plastic (slice mismatch)");
        return cellid_converter.position(cid).z();
    } catch (const std::exception& e) {
        cerr << "[WARN] getPlasticThicknessCM: " << e.what()
                << " (cellID=" << cid << ")\n";
        return std::numeric_limits<double>::quiet_NaN();;
    }

Full logs are here:
https://eicweb.phy.anl.gov/EIC/benchmarks/detector_benchmarks/-/jobs/7260369/raw
https://eicweb.phy.anl.gov/EIC/benchmarks/detector_benchmarks/-/jobs/7260357/raw
https://eicweb.phy.anl.gov/EIC/benchmarks/detector_benchmarks/-/jobs/7216516/raw

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove .so file and provide the source code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants