run_material_map_validation.sh: run material_comparison.py#1022
Open
run_material_map_validation.sh: run material_comparison.py#1022
Conversation
github-actions
bot
added
the
topic: infrastructure
There was a problem hiding this comment.
Pull request overview
This PR integrates the material_comparison.py script from the ACTS project into the material map validation workflow, providing a ROOT-independent alternative for generating material comparison plots.
Key changes:
- Added
material_comparison.pyto the list of ACTS files to download - Configured and executed the script with project-specific filenames and plot ranges
- Extended CI artifact collection to include generated SVG plots
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
scripts/material_map/run_material_map_validation.sh |
Downloads material_comparison.py, configures it via sed substitutions for local filenames and plot ranges, and executes it to generate comparison plots |
.github/workflows/linux-eic-shell.yml |
Adds SVG files to the material_map artifact collection to capture plots generated by material_comparison.py |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Produces a plot similar to one from Mat_map.C, but without ROOT.
Needs:
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No
Does this PR change default behavior?
No