Conversation
github-actions
bot
added
the
topic: infrastructure
Contributor
Author
|
@rahmans1 Please take a look and add any suggestions for geometries that you want exported to step as well. |
There was a problem hiding this comment.
Pull request overview
This PR fixes slow CI builds by limiting STEP file generation to only the detector configurations that are actually linked in the README.md, rather than generating files for all available configurations.
Changes:
- Removed dependency on
list-detector-configsjob to stop generating STEP files for all configurations - Hardcoded a specific list of 6 detector configurations that correspond to geometries linked in README.md
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
The convert-to-step actions runs slower and slower, and people keep adding more geometry configuration for their own niche uses. This PR restricts the generation of step files to only those geometries linked from the README.md.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.