Open
Conversation
Remove network_types parameter from workflow configuration.
Remove 'network_types' parameter from the workflow.
Removed the 'network_types' input from the workflow.
Remove network_types parameter from workflow.
There was a problem hiding this comment.
Pull request overview
Removes the deprecated/unrecognized network_types input from GitHub Actions workflows that invoke eic/run-cvmfs-osg-eic-shell, eliminating warnings from the action input validation.
Changes:
- Removed
network_typesfrom multiple workflowwith:blocks callingeic/run-cvmfs-osg-eic-shell@main.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/linux-eic-shell.yml | Removes deprecated network_types inputs across several jobs using the shell action. |
| .github/workflows/convert-to-tgeo.yml | Removes deprecated network_types input to stop unrecognized-input warnings. |
| .github/workflows/convert-to-step.yml | Removes deprecated network_types input to stop unrecognized-input warnings. |
| .github/workflows/convert-to-gdml.yml | Removes deprecated network_types input to stop unrecognized-input warnings. |
| .github/workflows/check-tracking-geometry.yml | Removes deprecated network_types input to stop unrecognized-input warnings. |
| .github/workflows/check-geometry-configs.yml | Removes deprecated network_types input to stop unrecognized-input warnings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
github-actions
bot
added
the
topic: infrastructure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This PR removes the
network_typesinput which was removed in eic/run-cvmfs-osg-eic-shell@b6d2aa6.What kind of change does this PR introduce?
network_typesinput, see e.g. annotations at https://github.com/eic/epic/actions/runs/22381173292)Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.