Add detailed nHCal geometry version using LFHCAL constructor by lkosarz · Pull Request #905 · eic/epic

lkosarz · 2025-07-07T20:41:16Z

Briefly, what does this PR introduce?

Adds a new detailed nHCal geometry implementation using LFHCAL constructor. Small update to the constructor.

Changed the cover plate material from Steel235 to be picked up based on absorber layers

What kind of change does this PR introduce?

Bug fix (issue #__)
New feature (issue #__)
Documentation update
Other: __

Please check if this PR fulfills the following:

Tests for the changes have been added
Documentation has been added / updated
Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

Does this PR change default behavior?

10 layers with 4 cm steel and 0.4 cm scintillator Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

…HCal-dev

Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

Co-authored-by: Wouter Deconinck <wdconinc@gmail.com>

Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

…nto negative-HCal-dev

Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

# Conflicts: # compact/definitions.xml # compact/hcal/hcal_backward.xml Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

Removed empty environments Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

Restored rmin and rmax to the decector parameter table Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

# Conflicts: # compact/definitions.xml # compact/hcal/backward.xml Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

# Conflicts: # compact/hcal/backward.xml Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

# Conflicts: # compact/definitions.xml # compact/hcal/backward.xml Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

…HCal-dev # Conflicts: # compact/definitions.xml # compact/hcal/backward.xml Signed-off-by: Kosarzewski <kosarzewski.1@asc.ohio-state.edu>

Changed air gap to 0.5mm = 2*LFHCAL Signed-off-by: Kosarzewski <kosarzewski.1@asc.ohio-state.edu>

Need cleanup Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

…-update

Signed-off-by: Kosarzewski <kosarzewski.1@asc.ohio-state.edu>

for more information, see https://pre-commit.ci

veprbl

Some early comments.

veprbl · 2025-07-07T21:44:23Z

compact/hcal/backward_LFHCAL_geo.xml

+    <documentation>
+      ### Forward (Positive Z) Endcap Hadronic Calorimeter
+
+      This is the ECCE LFHCAL design without individual tower placements and electronics
+      The original design was 60 layers of Steel/Sc and 10 layers of W/Sc, both 1.6 cm/0.4 cm
+      This is too long, so 5 layers of tungsten were removed as a placeholder until the final design is chosen
+
+      The HCal forward insert shape is cut out from this detector
+
+      Currently don't have an implementation of electronics, so just leave that area (final 10 cm) empty
+      So then, actual detector area is "nHCal_LFHCAL_length - LFHCALElectronicsThickness" long
+    </documentation>


Update or remove.

veprbl · 2025-07-07T21:45:20Z

compact/hcal/backward_LFHCAL_geo.xml

+<!--       <layer repeat="LFHCALLayer_NSteelRepeatS" vis="InvisibleWithDaughters" readoutlayer="4">
+        <slice material="Polystyrene" thickness="LFHCALPolystyreneThickness" vis="LFHCALLayerScintVis" sensitive="yes" limits="cal_limits" type="3" />
+        <slice material="Kapton" thickness="LFHCALKaptonThickness" vis="LFHCALLayerKaptonVis" type="2" offset="LFHCALAirOffset"/>
+        <slice material="StainlessSteelSAE304" thickness="LFHCALAbsorberThickness" vis="LFHCALLayerSteelVis" type="1"/>
+      </layer>
+      <layer repeat="LFHCALLayer_NSteelRepeatS" vis="InvisibleWithDaughters" readoutlayer="5">
+        <slice material="Polystyrene" thickness="LFHCALPolystyreneThickness" vis="LFHCALLayerScintVis" sensitive="yes" limits="cal_limits" type="3" />
+        <slice material="Kapton" thickness="LFHCALKaptonThickness" vis="LFHCALLayerKaptonVis" type="2" offset="LFHCALAirOffset"/>
+        <slice material="StainlessSteelSAE304" thickness="LFHCALAbsorberThickness" vis="LFHCALLayerSteelVis" type="1"/>
+      </layer>
+      <layer repeat="LFHCALLayer_NSteelRepeatS" vis="InvisibleWithDaughters" readoutlayer="6">
+        <slice material="Polystyrene" thickness="LFHCALPolystyreneThickness" vis="LFHCALLayerScintVis" sensitive="yes" limits="cal_limits" type="3" />
+        <slice material="Kapton" thickness="LFHCALKaptonThickness" vis="LFHCALLayerKaptonVis" type="2" offset="LFHCALAirOffset"/>
+        <slice material="StainlessSteelSAE304" thickness="LFHCALAbsorberThickness" vis="LFHCALLayerSteelVis" type="1"/>
+      </layer>-->


Suggested change

veprbl · 2025-07-07T21:45:45Z

compact/hcal/backward_LFHCAL_geo.xml

+      <documentation>
+        ### for testing of a single module
+      </documentation>
+       <!-- <eightmodulepositions name="xpos" unit="cm" values="15 35"/>
+        <eightmodulepositions name="ypos" unit="cm" values="15 35"/> -->
+        <!-- <eightmodulepositions name="zpos" unit="cm" values="0 0"/> -->
+        <!-- <fourmodulepositions name="xpos" unit="cm" values="-25 -35"/>
+        <fourmodulepositions name="ypos" unit="cm" values="-25 -35"/>
+        <fourmodulepositions name="zpos" unit="cm" values="0 0"/> -->
+
+


Suggested change

<documentation>

### for testing of a single module

</documentation>

veprbl · 2025-07-07T21:48:15Z

compact/hcal/backward_LFHCAL_geo.xml

+  <info name="lfhcal.xml"
+        title="EPIC LFHCAL"
+        author="@FriederikeBock"
+        url="https://github.com/FriederikeBock"


Suggested change

<info name="lfhcal.xml"

title="EPIC LFHCAL"

author="@FriederikeBock"

url="https://github.com/FriederikeBock"

<info name="backward_LFHCAL_geo.xml"

title="EPIC nHcal"

author="@lkosarz"

url="https://github.com/lkosarz"

veprbl · 2025-07-10T17:21:51Z

compact/hcal/backward_LFHCAL_geo.xml

+        />
+        <position x="50*cm" y="60*cm" z="nHCal_LFHCAL_length - LFHCALElectronicsThickness" />
+      </fourmodule>
+      <layer repeat="LFHCALLayer_NSteelRepeatSFirst" vis="InvisibleWithDaughters" readoutlayer="0">


Are these constructed in order of decreasing $z$? Should we at least invert the indexing?

I'll update this in the next step.

veprbl · 2025-07-10T17:23:29Z

compact/hcal/backward_LFHCAL_geo.xml

+    <constant name="Mod_PCBWidth"             value="70* mm"/>
+    <constant name="Mod_PCBThickness"         value="4* mm"/>
+    <constant name="Mod_PCBLength"            value="61.0* cm"/>
+    <constant name="Mod_PCBOffset"            value="0.28* cm+"/>


Suggested change

<constant name="Mod_PCBOffset" value="0.28* cm+"/>

<constant name="Mod_PCBOffset" value="0.28* cm"/>

veprbl · 2025-07-10T17:25:11Z

compact/hcal/backward_LFHCAL_geo.xml

+    <constant name="FourM_OuterHeight"        value="10.1* cm"/>
+    <constant name="FourM_BackInnerWidth"     value="7.0* cm"/>
+    <constant name="FourM_BackInnerHeight"    value="7.0* cm"/>
+    <constant name="FourM_NotchHeight"        value="75* mm"/>


The constants are not scoped. Once you try to integrate, you'll discover a need to have a namespace. I would suggest to use HcalEndcapN prefix wherever possible and remove references to LFHCAL to avoid confusion.

Updated description Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

…to nHCal-dev-update # Conflicts: # compact/hcal/backward_LFHCAL_geo.xml

for more information, see https://pre-commit.ci

TODO: invert numbering along z (not necessary for now) Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

…to nHCal-dev-update

Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

for more information, see https://pre-commit.ci

Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

…to nHCal-dev-update

Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

Made 5x thicker version for sampling fraction study Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

Undetected by overlap check! Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

lkosarz and others added 30 commits September 21, 2022 08:39

Updated nHCal with segmentation based on STAR EEMC

6a8f3db

10 layers with 4 cm steel and 0.4 cm scintillator Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

Moved to other HcalEndcapN definitions

e22c942

Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

Placing fixed to HcalEndcapN

b5e1f44

Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

Testing 12 bins in R (eta) for nHCal

b0cb821

Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

Merge branch 'main' of https://github.com/eic/epic.git into negative-…

ef53f99

…HCal-dev

First try of extrapolating tlie sizes

5f97a5b

Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

Updated extrapolated bins in R with a linear fit in eta

11f5515

Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

Merge branch 'main' into negative-HCal-dev

fd739ee

Update compact/definitions.xml

abe1c97

Co-authored-by: Wouter Deconinck <wdconinc@gmail.com>

Update compact/definitions.xml

d640e5b

Co-authored-by: Wouter Deconinck <wdconinc@gmail.com>

Updated number of bins in phi from 36x6*deg to 60x6*deg

0073189

Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

Merge branch 'negative-HCal-dev' of https://github.com/eic/epic.git i…

3cbf661

…nto negative-HCal-dev

fix: extend HcalEndcapN r segments to rmin/rmax

2b5abcf

Shrink nHCal size to the segmentation limits

b84a517

Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

Merge branch 'master' into hcal-backward-segmentation-r

b0c37f7

Merge branch 'master' into negative-HCal-dev

6c67e0b

# Conflicts: # compact/definitions.xml # compact/hcal/hcal_backward.xml Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

Merge branch 'hcal-backward-segmentation-r' into negative-HCal-dev

ef1052d

Moved HcalEndcapN radii to hcal/hcal_backward.xml

c3b2710

Removed empty environments Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

Added HcalEndcapN_rmin and HcalEndcapN_rmax to segmentation limits

6f270f5

Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

Moved nHCal dimensions defintions to compact file

a4961f9

Restored rmin and rmax to the decector parameter table Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

Added missing comment

ca2a745

Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

Fix issue #277 - error due to hits hitting nHCal corners

bb57fe2

Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

Merge branch 'master' into hcal-backward-segmentation-r

67e1157

# Conflicts: # compact/definitions.xml # compact/hcal/backward.xml Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

Merge branch 'hcal-backward-segmentation-r'

6487285

# Conflicts: # compact/hcal/backward.xml Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

Merge branch 'main' of https://github.com/eic/epic.git

623851d

Change to CartesianGridXY 10cm*10cm segments

f665d86

Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

Merge branch 'master' into negative-HCal-dev

32c43e7

# Conflicts: # compact/definitions.xml # compact/hcal/backward.xml Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

Correct missing quotation marks

a3133cd

Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

Merge branch 'main' of https://github.com/eic/epic.git into negative-…

fb16a33

…HCal-dev # Conflicts: # compact/definitions.xml # compact/hcal/backward.xml Signed-off-by: Kosarzewski <kosarzewski.1@asc.ohio-state.edu>

Restored 10cm*10cm segmentation

f56d6dc

Changed air gap to 0.5mm = 2*LFHCAL Signed-off-by: Kosarzewski <kosarzewski.1@asc.ohio-state.edu>

lkosarz and others added 8 commits July 4, 2025 03:28

Merge branch 'main' of https://github.com/eic/epic.git

fd12437

Merge branch 'main' into nHCal-dev-update

eb42949

Added nHCal using LFHCAL geometry

2710675

Need cleanup Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

Fixed plate material setting to same as absorber

4146845

Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

Implemented PCB offset

03be837

Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

Merge branch 'main' of https://github.com/eic/epic.git into nHCal-dev…

6e90943

…-update

Merge branch 'main' of https://github.com/eic/epic.git

4715220

Fixed missing param from constructors

6b64f8c

Signed-off-by: Kosarzewski <kosarzewski.1@asc.ohio-state.edu>

lkosarz requested review from FriederikeBock and veprbl July 7, 2025 20:41

github-actions bot added topic: backward Negative-rapidity detectors (electron-going side) topic: calorimetry labels Jul 7, 2025

[pre-commit.ci] auto fixes from pre-commit.com hooks

768a22f

for more information, see https://pre-commit.ci

veprbl reviewed Jul 10, 2025

View reviewed changes

lkosarz and others added 16 commits July 11, 2025 04:46

Added nHCal specific variable names to avoid clash "HcalEndcapN_"

a556d11

Updated description Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

Merge branch 'nHCal-dev-update' of https://github.com/eic/epic.git in…

a1d500b

…to nHCal-dev-update # Conflicts: # compact/hcal/backward_LFHCAL_geo.xml

[pre-commit.ci] auto fixes from pre-commit.com hooks

efbb860

for more information, see https://pre-commit.ci

Updated info

5c2ccd9

TODO: invert numbering along z (not necessary for now) Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

Merge branch 'nHCal-dev-update' of https://github.com/eic/epic.git in…

d2250a4

…to nHCal-dev-update

Reversed order of layers - correct!

7a4e7ff

Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

[pre-commit.ci] auto fixes from pre-commit.com hooks

fae37b0

for more information, see https://pre-commit.ci

Replace default with LFHCAL-type

d330993

Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

Merge branch 'nHCal-dev-update' of https://github.com/eic/epic.git in…

a302d73

…to nHCal-dev-update

Reverted change

f09c123

Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

Merge branch 'main' of https://github.com/eic/epic.git

3c27fc3

Merge branch 'main' into nHCal-dev-update

0a6c937

Changed geometry to 10x 4 cm steel and 24 mm plastic

b1b970a

Made 5x thicker version for sampling fraction study Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

Removed endcap flux due to potential overlaps

15aff74

Undetected by overlap check! Signed-off-by: lkosarz <leszek.kosarzewski@gmail.com>

Merge branch 'main' of https://github.com/eic/epic.git

59b9c8d

Merge branch 'main' into nHCal-dev-update

5c29863

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add detailed nHCal geometry version using LFHCAL constructor#905

Add detailed nHCal geometry version using LFHCAL constructor#905
lkosarz wants to merge 126 commits intomainfrom
nHCal-dev-update

lkosarz commented Jul 7, 2025 •

edited

Loading

Uh oh!

veprbl left a comment

Uh oh!

veprbl Jul 7, 2025

Uh oh!

veprbl Jul 7, 2025

Uh oh!

veprbl Jul 7, 2025

Uh oh!

veprbl Jul 7, 2025

Uh oh!

veprbl Jul 10, 2025

Uh oh!

lkosarz Jul 11, 2025

Uh oh!

veprbl Jul 10, 2025

Uh oh!

veprbl Jul 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	<constant name="Mod_PCBOffset" value="0.28* cm+"/>
	<constant name="Mod_PCBOffset" value="0.28* cm"/>

Conversation

lkosarz commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Briefly, what does this PR introduce?

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

Does this PR introduce breaking changes? What changes might users need to make to their code?

Does this PR change default behavior?

Uh oh!

veprbl left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lkosarz commented Jul 7, 2025 •

edited

Loading