feat: DetectorChecksumRunAction to write checksums to podio#32
Open
feat: DetectorChecksumRunAction to write checksums to podio#32
Conversation
wdconinc
force-pushed
the
detector-checksum-run-action
branch
from
0c3b8f4 to
787e599
Compare
wdconinc
commented
Apr 26, 2025
wdconinc
force-pushed
the
detector-checksum-run-action
branch
from
30c5cc4 to
155c3bb
Compare
Contributor
Author
|
Remaining issue here: |
wdconinc
force-pushed
the
detector-checksum-run-action
branch
from
155c3bb to
8ecaf79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This PR determines the detector checksums for all detectors, and writes them to the run metadata of the output file.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
Yes, it will by default calculate the checksums.
Calculating the checksum currently takes about 20 to 30 seconds in CI (https://github.com/eic/epic/actions/runs/14718107525/job/41444662641#step:5:252), though locally this can take up to 50 seconds. The checksum can be disabled with the npsim argument
--disableChecksum.