feat: add performance profiler as stepping action#35
Open
Conversation
Contributor
Author
|
This now produces plots like this: |
8 tasks
wdconinc
force-pushed
the
performance-profiling
branch
from
e900a82 to
700371a
Compare
veprbl
reviewed
Jun 25, 2025
|
|
||
| RUNNER.action.step = { | ||
| "name": "PerformanceProfileSteppingAction" | ||
| } |
Contributor
Author
There was a problem hiding this comment.
I want to add an argparse after https://github.com/eic/npsim/pull/32/files#diff-ec66169d33f9f45a183f1276f7d09c786eca03516f48b1ff756e3c5ed439cff8R24
rahmans1
pushed a commit
to eic/detector_benchmarks
that referenced
this pull request
Oct 22, 2025
…alysis This benchmark measures computational performance of detector simulation by profiling time spent in different detector regions during Geant4 stepping. - Add benchmarks/timing_profiling/ with run_profile.sh and analysis scripts - Integrate with CI/CD pipeline via .gitlab-ci.yml - Uses PerformanceProfileSteppingAction plugin to collect timing data - Generates annotated plots showing computational hotspots in detector geometry - Outputs CSV summaries of timing by detector region Requires: eic/npsim#35 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This PR adds a performance profiler plugin as a stepping action. For each step it keeps track of the duration that it is being simulated (this only works for default stacking actions), and at the end of run lists all tracks that took longer than 10 ms to simulate, along with their PDG and start/end position.
Example output:
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.