forked from typetools/checker-framework
-
Notifications
You must be signed in to change notification settings - Fork 29
Handle Rawtype more gracefully #1438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aosen-xiong
wants to merge
15
commits into
eisop:master
Choose a base branch
from
aosen-xiong:eisop-792
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+18
−0
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
84daaaf
Add example to show the crash
aosen-xiong 2a374b5
Add fix
aosen-xiong e161f8e
Optimize logic and update changelog
aosen-xiong d596468
Merge branch 'master' into eisop-792
aosen-xiong 08171af
Merge branch 'master' into eisop-792
aosen-xiong 4a7f361
Try new approach
aosen-xiong dd7b586
Merge branch 'master' into eisop-792
aosen-xiong 32e42ad
Clarify raw type wildcard propagation
aosen-xiong a63bd2c
Fix changelog punctuation
aosen-xiong ffdd715
Clarify raw wildcard propagation comment
aosen-xiong 8bf8a17
Merge branch 'master' into eisop-792
aosen-xiong 55be02c
Merge branch 'master' into eisop-792
aosen-xiong 2627a64
Merge branch 'master' into eisop-792
wmdietl fc3b1f6
Add all-systems rawtype crash coverage
aosen-xiong 9237f06
Merge branch 'master' into eisop-792
aosen-xiong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| @SuppressWarnings("all") // Raw type use is intentional: this is a no-crash regression test. | ||
| public class RawtypeCrash<V> { | ||
| RawtypeCrash<? extends V> nullObj = null; | ||
| Object obj = ((RawtypeCrash) null).nullObj; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| public class RawtypeCrash<V> { | ||
| RawtypeCrash<? extends V> nullObj = null; | ||
| Object obj = ((RawtypeCrash) null).nullObj; | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this problem specific to the viewpoint checker?
Would it be better to add to
all-systems(possibly suppressing all warnings to just check for the crash)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried Nullness, Interning, and Tainting checkers and did not see this BugInCF crash from RawtypeCrash there.
Do you think we should keep it in the viewpoint checker tests or move it
all-systems?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the only checker that is breaking with this code is the Viewpoint Checker, maybe it needs a change? Why does no other type checker fail with this code? Doesn't that indicate that the VP Checker is doing something wrong?
In any case, isn't this another argument to move it to
all-systems, to ensure that all type systems work with this code?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried adding all-systems to ViewpointTestCheckerTest. It exposes many additional viewpoint-checker failures/crashes, so enabling it wholesale is a follow-up task.
For this PR, I will keep the small duplicated viewpointtest/RawtypeCrash.java. The all-systems copy provides useful broad coverage, but by itself it does not exercise the viewpoint checker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other failures are also discussed in #433.