Skip to content

Fix jspecify-conformance build #1750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wmdietl merged 3 commits into from
Jun 4, 2026
Merged

Fix jspecify-conformance build #1750

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c976d2e
Fix jspecify-conformance build
wmdietl Jun 4, 2026
53f81a0
Apply suggestions from code review
wmdietl Jun 4, 2026
afecdc2
Apply suggestions from code review
wmdietl Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 35 additions & 1 deletion checker/bin-devel/test-jspecify-conformance.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,41 @@ source "$SCRIPT_DIR"/clone-related.sh
./gradlew assembleForJavac --console=plain -Dorg.gradle.internal.http.socketTimeout=60000 -Dorg.gradle.internal.http.connectionTimeout=60000

"$SCRIPT_DIR/.git-scripts/git-clone-related" eisop jspecify-conformance
"$SCRIPT_DIR/.git-scripts/git-clone-related" jspecify jspecify
"$SCRIPT_DIR/.git-scripts/git-clone-related" jspecify jspecify-reference-checker

# Build conformance test artifacts locally.
# This duplicates logic from jspecify-conformance/.github/workflows/workflow.yml

trap 'rm -f /tmp/publish-helper.gradle' EXIT
cat > /tmp/publish-helper.gradle << 'INIT'
allprojects {
pluginManager.apply('maven-publish')
tasks.withType(Sign).configureEach { enabled = false }
}
INIT

cd ../jspecify
./gradlew --console=plain --warning-mode=all --init-script /tmp/publish-helper.gradle :conformance-tests:publishToMavenLocal

cd ../jspecify-reference-checker
cat > conformance-test-framework/settings.gradle << 'SETTINGS'
rootProject.name = 'conformance-test-framework'
dependencyResolutionManagement {
versionCatalogs {
libs {
library('guava', 'com.google.guava:guava:33.6.0-jre')
library('jspecify', 'org.jspecify:jspecify:1.0.0')
library('truth', 'com.google.truth:truth:1.4.5')
library('junit', 'junit:junit:4.13.2')
}
}
}
SETTINGS
./gradlew --project-dir conformance-test-framework \
--console=plain --warning-mode=all --init-script /tmp/publish-helper.gradle publishToMavenLocal

cd ../jspecify-conformance
# This does not use "-PcfVersion=local", because that project does not
# use the CF gradle plugin.
./gradlew test --console=plain -PcfLocal
./gradlew test --console=plain --warning-mode=all -PcfLocal
Loading