Skip to content

Fix build by locally building JSpecify conformance artifacts#141

Merged
wmdietl merged 13 commits into
mainfrom
fix-build
Jun 4, 2026
Merged

Fix build by locally building JSpecify conformance artifacts#141
wmdietl merged 13 commits into
mainfrom
fix-build

Conversation

@wmdietl

@wmdietl wmdietl commented Jun 1, 2026

Copy link
Copy Markdown
Member

Largely with the help of Claude from the CI failure.

Copilot AI review requested due to automatic review settings June 1, 2026 00:15

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to fix CI/build breakages by making resolution of the JSpecify conformance snapshot more robust, ensuring required test dependencies are declared explicitly, and correcting a few build/test runner and documentation details.

Changes:

  • Add mavenLocal() fallback plus repository content scoping for the org.jspecify.conformance snapshot artifacts, and declare an explicit Guava test dependency.
  • Fix dependency path parsing in the conformance test runner by omitting empty entries.
  • Update CI to build/install the JSpecify snapshot to the local Maven repo, and fix a README Gradle command typo.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
src/test/java/conformance/NullnessJSpecifyConformanceTest.java Improves deps parsing by omitting empty path entries when splitting.
README.md Fixes the Gradle command typo (assemble).
build.gradle Adds mavenLocal() fallback + scoped snapshots repo, and explicitly depends on Guava for tests.
.github/workflows/workflow.yml Builds/publishes the JSpecify snapshot into Maven Local during CI and fixes the matrix variable name in a step label.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wmdietl wmdietl mentioned this pull request Jun 4, 2026
@wmdietl wmdietl changed the title Fix build Fix build by locally building JSpecify conformance artifacts Jun 4, 2026
@wmdietl wmdietl merged commit 0413f74 into main Jun 4, 2026
6 checks passed
@wmdietl wmdietl deleted the fix-build branch June 4, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants