Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to fix CI/build breakages by making resolution of the JSpecify conformance snapshot more robust, ensuring required test dependencies are declared explicitly, and correcting a few build/test runner and documentation details.
Changes:
- Add
mavenLocal()fallback plus repository content scoping for theorg.jspecify.conformancesnapshot artifacts, and declare an explicit Guava test dependency. - Fix dependency path parsing in the conformance test runner by omitting empty entries.
- Update CI to build/install the JSpecify snapshot to the local Maven repo, and fix a README Gradle command typo.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/test/java/conformance/NullnessJSpecifyConformanceTest.java |
Improves deps parsing by omitting empty path entries when splitting. |
README.md |
Fixes the Gradle command typo (assemble). |
build.gradle |
Adds mavenLocal() fallback + scoped snapshots repo, and explicitly depends on Guava for tests. |
.github/workflows/workflow.yml |
Builds/publishes the JSpecify snapshot into Maven Local during CI and fixes the matrix variable name in a step label. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Largely with the help of Claude from the CI failure.