fix: resolve SIGSEGV on thread view by correcting snprintf parameter order#17
Merged
Merged
Conversation
…o prevent SIGSEGV Fix critical SIGSEGV crash occurring when accessing a thread page due to mismatched snprintf parameter types and order in thread_view_handler. Now parameters match the format specifier types and positions, addressing a major user-facing reliability issue. - Corrected the order and types of parameters in snprintf for thread HTML page generation - Added test script to verify thread creation and access are stable - Confirmed issue is fully resolved and the app is now stable under multiple thread accesses This fix resolves an urgent usability issue and ensures all thread-related views work reliably for users.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves a critical segmentation fault (SIGSEGV) when accessing thread pages by correcting the snprintf parameter order in the thread view handler.
Details
thread_view_handlerso that they match the format string, fixing a crash when viewing threads.Warning: Task VM test is not passing, cto.new will perform much better if you fix the setup