Conversation
pebie
force-pushed
the
master
branch
3 times, most recently
from
January 14, 2022 13:46
2a1f5cd to
7fa350d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is in response to #24
I try to make the snapshot support
Scenario OutlinesThe snapshots developed by @bnadim didn't work with Scenario Outlines, @plouc pointed that out, and I tried to solve the problem as best as I can. I am still willing to refine my code until this PR's is acceptable and merged :)
Test plan
To test this, I added one test to
examples/filters/snapshot/snapshot.featurewhich is a Scenario Outline where the examples are somewhat scattered across multiple lines, so as to test that the blank lines and comments are ignored.To run my tests, I used this command
cucumberjs --require examples/support examples/features --tags @snapshot