Document encoder setup and report mpv startup failures - #222
Merged
Merged
Conversation
ekisu
force-pushed
the
fix/issue-163
branch
from
September 12, 2026 01:15
630ea10 to
d70e7f2
Compare
ekisu
commented
Sep 12, 2026
ekisu
left a comment
Owner
Author
There was a problem hiding this comment.
Could we also add a better error message when encoding fails due to mpv not being present?
ekisu
force-pushed
the
fix/issue-163
branch
from
September 12, 2026 19:40
d70e7f2 to
bb173b7
Compare
Owner
Author
|
Approved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Document that encoding launches a second
mpvprocess and requires the player's inherited PATH to include the executable. Add Windows and macOS/Linux checks, distinguish shell PATH from desktop launch environments, and explain mpv's own codec availability.Fixes #163 (requested installation-instruction revision).
Related support reports: #135, #188, #202, #77.
Tracked in #217.
Verification
"mpv"child command insrc/encode.moonand both subprocess paths insrc/util.moon.command -v mpv,mpv --ovc=help, andmpv --oac=helpwork on the local Linux installation.Latest rebase verification
Rebased onto master
72d9d11after #227 merged. Normal build and the complete pinned-Nix suite pass, with two expected skips (audio fixture and unavailable optional libaom-av1 encoder).Review feedback addressed — 2026-09-12
Added a linked step-by-step Windows encoder setup guide and an actionable startup error for a missing/unlaunchable mpv executable. A preflight runs before normal, progress, detached and two-pass launch paths. Real mpv is started by absolute path with an empty PATH to test the failure without mocks. Full pinned-Nix suite: 28 tests, 26 passed and 2 expected skips. GitHub build/test checks pass.
Rebased onto master after #220, #221, #223 and #224 merged.