Conversation
ekisu
force-pushed
the
fix/subtitles-after-crop
branch
from
September 21, 2026 03:24
8567f72 to
0666910
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Render subtitles after the crop/scale video pipeline and before GIF palette generation. The preview now applies crop before the subtitle filter as well, matching normal mpv playback.
Evidence
Exact playback command:
Real mpv output confirms the video filter produces
1920x800before subtitle OSD rendering:mpv 0.41 log
Generated GIF from the same 1920x1080 source, embedded subtitle, crop, and 540px output scale:
Validation
Tests cover GIF subtitles/palette handling, lavfi crop, lavfi graphs, EQ filters, and AVC crop handling.