Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dependency updates to address requested updates from the detection-rules-explorer dependency PRs, applied without introducing errors.
axios:
devDependenciesuses an exact pin to 1.13.4 instead of^1.14.0, so installs stay on the 1.13.x line and do not float to 1.14.x.Testing
Screenshots
Local Test Steps
Use either the commands from the README if you wish to use your local node installation, or use the following Docker container to test.
Docker Instructions
Clone
detection-rules-explorerand cd into the newly cloned directoryCreate a
Dockerfilewith the following contentsDockerfile
Run
docker build -t rules_explorer_test .to build the containerRun
docker run rules_explorer_testto start the containerNavigate to
10.10.0.2:3000to view the explorer (note this is http NOT https)Note this IP address may be different for you depending on your Docker setup or if you are running additional containers.
You can use the
docker container listcommand to find your running containerExample
❯ docker container list CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES c0a434dbfde6 rules_explorer_test "docker-entrypoint.s…" 37 seconds ago Up 37 seconds 443/tcp determined_lehmannNow you can grab the
CONTAINER IDand use it to get the IP address via the followingdocker inspect <container_id> | grep IPAddressExample
Check to make sure the website renders as intended.