Skip to content

Conversation

@kevin-dp
Copy link
Contributor

Rebases #2544 on latest main

Co-authored-by: Kevin <kevin@electric-sql.com>
@codecov
Copy link

codecov bot commented Jun 27, 2025

Codecov Report

Attention: Patch coverage is 64.97175% with 62 lines in your changes missing coverage. Please review.

Project coverage is 77.64%. Comparing base (f4cb5c1) to head (dd84d2e).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
packages/sync-service/lib/electric/shapes/api.ex 49.18% 31 Missing ⚠️
packages/typescript-client/src/client.ts 71.76% 24 Missing ⚠️
packages/typescript-client/src/helpers.ts 0.00% 4 Missing ⚠️
...es/sync-service/lib/electric/shapes/api/encoder.ex 75.00% 1 Missing ⚠️
...ages/sync-service/lib/electric/shapes/api/error.ex 75.00% 1 Missing ⚠️
packages/typescript-client/src/fetch.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2856      +/-   ##
==========================================
- Coverage   78.04%   77.64%   -0.40%     
==========================================
  Files         156      156              
  Lines        7337     7462     +125     
  Branches      275      287      +12     
==========================================
+ Hits         5726     5794      +68     
- Misses       1609     1666      +57     
  Partials        2        2              
Flag Coverage Δ
elixir 76.68% <59.25%> (-0.23%) ⬇️
elixir-client 73.03% <ø> (ø)
packages/experimental 87.73% <ø> (ø)
packages/react-hooks 86.30% <ø> (ø)
packages/typescript-client 89.37% <69.79%> (-3.20%) ⬇️
packages/y-electric 55.12% <ø> (ø)
postgres-140000 76.70% <59.25%> (-0.33%) ⬇️
postgres-150000 76.86% <59.25%> (-0.22%) ⬇️
postgres-170000 76.83% <59.25%> (-0.30%) ⬇️
sync-service 77.17% <59.25%> (-0.26%) ⬇️
typescript 82.87% <69.79%> (-1.59%) ⬇️
unit-tests 77.64% <64.97%> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@alco alco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

I have refactored the Elixir code to piggy-back off the opts argument in the get_merged_log_stream() function instead of adding another argument to it.

Also, passing options instead of just a boolean value to must_refetch() makes the code a tinsy bit more readable.

@alco
Copy link
Member

alco commented Jun 27, 2025

This test keeps failing no matter how many times I rerun it. Doesn't look like flake.

HTTP Proxy Cache > should get fresh response when age is passed the stale age 5015ms
     → Test timed out in 5000ms.

@kevin-dp
Copy link
Contributor Author

This test keeps failing no matter how many times I rerun it. Doesn't look like flake.

HTTP Proxy Cache > should get fresh response when age is passed the stale age 5015ms
     → Test timed out in 5000ms.

Yes, this test started failing when i upgraded Vitest to v3. If i downgrade it back to v2 it passes again..

@kevin-dp
Copy link
Contributor Author

@alco i fixed the failing unit test. It seems that Vitest v3 ignores the "timeout" configuration on the describe block. So i removed it and added a custom timeout for the caching test. It's green now.

@kevin-dp kevin-dp merged commit c59000f into main Jun 30, 2025
40 checks passed
@kevin-dp kevin-dp deleted the kevin/sse-rebase branch June 30, 2025 09:28
3dyuval pushed a commit to 3dyuval/electric that referenced this pull request Aug 23, 2025
…ql#2856)

---------

Co-authored-by: James Arthur <thruflo@gmail.com>
Co-authored-by: Oleksii Sholik <oleksii@sholik.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants