-
Notifications
You must be signed in to change notification settings - Fork 295
feat: experimental support for streaming SSE in live mode #2856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Kevin <kevin@electric-sql.com>
64eb322 to
1afa1a0
Compare
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #2856 +/- ##
==========================================
- Coverage 78.04% 77.64% -0.40%
==========================================
Files 156 156
Lines 7337 7462 +125
Branches 275 287 +12
==========================================
+ Hits 5726 5794 +68
- Misses 1609 1666 +57
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…t (requires Vitest v3)
Adding a new argument to the get_merged_log_stream() function is odd given that it already takes an "options" argument. So this commit adds a new option instead.
alco
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
I have refactored the Elixir code to piggy-back off the opts argument in the get_merged_log_stream() function instead of adding another argument to it.
Also, passing options instead of just a boolean value to must_refetch() makes the code a tinsy bit more readable.
|
This test keeps failing no matter how many times I rerun it. Doesn't look like flake. |
Yes, this test started failing when i upgraded Vitest to v3. If i downgrade it back to v2 it passes again.. |
|
@alco i fixed the failing unit test. It seems that Vitest v3 ignores the "timeout" configuration on the |
…ql#2856) --------- Co-authored-by: James Arthur <thruflo@gmail.com> Co-authored-by: Oleksii Sholik <oleksii@sholik.dev>
Rebases #2544 on latest main