Skip to content

chore: allow overriding main.star and backend.star #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkleinsc merged 2 commits into from
Mar 24, 2026
+9 −2
Merged

chore: allow overriding main.star and backend.star #819

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9fd2e8
chore: allow overriding main.star and backend.star
jkleinsc Mar 19, 2026
193d448
chore: apply review feedback
jkleinsc Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/utils/siso.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,13 @@ const sisoEnv = (config) => {
return sisoEnv;
};

function getStarFile(envVar, filename) {
if (process.env[envVar] && fs.existsSync(process.env[envVar])) {
return process.env[envVar];
}
return path.resolve(__dirname, '../../tools', filename);
}

function sisoFlags(config, hasExecute) {
if (config.remoteBuild !== 'siso') return [];

Expand All @@ -34,7 +41,7 @@ function sisoFlags(config, hasExecute) {
'-reapi_address',
reclient.serviceAddress(config),
'-load',
path.resolve(__dirname, '../../tools/main.star'),
getStarFile('ELECTRON_BUILD_TOOLS_MAIN_STAR', 'main.star'),
];

if (!hasExecute) {
Expand All @@ -54,7 +61,7 @@ async function ensureBackendStarlark(config) {
);
}

const backendConfig = path.resolve(__dirname, '../../tools/backend.star');
const backendConfig = getStarFile('ELECTRON_BUILD_TOOLS_BACKEND_STAR', 'backend.star');
const starlarkPath = path.resolve(starlarkDir, 'backend.star');
let needsUpdate = true;
if (fs.existsSync(starlarkPath)) {
Expand Down