Skip to content

feat(e-rcv): support devtools CLs #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dsanders11 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(e-rcv): support devtools CLs #825

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions src/e-rcv.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,14 @@ const ELECTRON_REPO_DATA = {
repo: 'electron',
};
const DEPS_REGEX = new RegExp(`chromium_version':\n +'(.+?)',`, 'm');
const CHROMIUM_CL_REGEX =
/https:\/\/chromium-review\.googlesource\.com\/c\/chromium\/src\/\+\/(\d+)/;
const V8_CL_REGEX = /https:\/\/chromium-review\.googlesource\.com\/c\/v8\/v8\/\+\/(\d+)/;
const CL_REGEX =
/https:\/\/chromium-review\.googlesource\.com\/c\/(chromium\/src|devtools\/devtools-frontend|v8\/v8)\/\+\/(\d+)(#\S+)?/;

const REPO_LABELS = {
chromium: chalk.magenta('Chromium'),
devtools: chalk.blue('DevTools'),
v8: chalk.cyan('V8'),
};

async function getChromiumVersion(octokit, ref) {
const { data } = await octokit.repos.getContent({
Expand Down Expand Up @@ -311,18 +316,15 @@ program
const shortSha = commit.sha.substring(0, 7);
const message = commit.commit.message.split('\n')[0];

const chromiumCLMatch = CHROMIUM_CL_REGEX.exec(commit.commit.message);
const v8CLMatch = V8_CL_REGEX.exec(commit.commit.message);
const clMatch = CL_REGEX.exec(commit.commit.message);

const clMatch = chromiumCLMatch || v8CLMatch;
if (!clMatch) {
console.info(`${color.info} Skipping non-CL commit: ${chalk.yellow(shortSha)} ${message}`);
continue;
}

const isV8 = !!v8CLMatch;
const repo = isV8 ? 'v8' : 'chromium';
const label = isV8 ? chalk.cyan('V8') : chalk.magenta('Chromium');
const repo = clMatch[1].split('/')[0];
const label = REPO_LABELS[repo];

const parsedUrl = new URL(clMatch[0]);

Expand Down