feat: add jobs option to control node-gyp parallel compilation - #1290
Merged
Conversation
Native module builds ran single-threaded because rebuild never passed node-gyp a job count. Add a flat `jobs` option (CLI `--jobs`/`-j`) that is threaded through RebuildOptions -> IRebuilder -> buildArgs and emitted as node-gyp's `--jobs=<n>` flag when set. Closes #303
MarshallOfSound
approved these changes
Jul 1, 2026
MarshallOfSound
marked this pull request as ready for review
July 1, 2026 05:48
erickzhao
approved these changes
Jul 3, 2026
|
🎉 This PR is included in version 4.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Samuel Attard · Slack thread
Before
Native module compilation always ran single-threaded because rebuild never passed node-gyp a job count, leaving node-gyp to build with a single compile job.
After
Callers can set a
jobsoption (or the--jobs/-jCLI flag) to control how many parallel compile jobs node-gyp runs. When unset, node-gyp's own default is used, so existing behavior is unchanged.How
A flat top-level
jobs?: numberoption is threaded throughRebuildOptions→IRebuilder→buildArgs(), matching the existing flat convention (arch,debug, etc.) rather than a nested bag. InbuildArgs()the value is emitted as node-gyp's--jobs=<n>flag only when set. The CLI exposes it as--jobs/-j, validated as numeric and passed into the rebuild call.Closes #303