rebuild: include prefix when filtering with --only - #850
Draft
paul-marechal wants to merge 2 commits into
Draft
Conversation
Contributor
Author
|
I'm not sure if I should just replace |
paul-marechal
force-pushed
the
mp/fix-only
branch
from
September 2, 2021 22:24
9208213 to
d53dedc
Compare
malept
previously requested changes
Sep 2, 2021
malept
left a comment
malept
left a comment
Member
There was a problem hiding this comment.
I think this needs tests for regression purposes.
Codecov Report
@@ Coverage Diff @@
## master #850 +/- ##
=======================================
Coverage 75.89% 75.89%
=======================================
Files 17 17
Lines 672 672
Branches 130 130
=======================================
Hits 510 510
Misses 118 118
Partials 44 44
Continue to review full report at Codecov.
|
The logic currently ignores a module prefix when filtering packages passed via `--only=`. This is quite confusing: to only rebuild something like `@theia/node-pty` we must pass `--only=node-pty`. This commit adds a lookup using the prefixed name.
paul-marechal
force-pushed
the
mp/fix-only
branch
2 times, most recently
from
September 6, 2021 03:20
2d375d0 to
f23eddf
Compare
paul-marechal
force-pushed
the
mp/fix-only
branch
from
September 6, 2021 03:37
f23eddf to
d84d91e
Compare
Contributor
Author
|
I added tests, but I'll need to close this PR temporarily, I will re-open when ready. |
Contributor
Author
|
Ready to go again. |
Member
|
drafting due to conflicts. i think i can work on resolving them and getting this shipped. |
erickzhao
marked this pull request as draft
November 7, 2023 22:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic currently ignores a module prefix when filtering packages
passed via
--only=. This is quite confusing: to only rebuildsomething like
@theia/node-ptywe must pass--only=node-pty.This commit adds a lookup using the prefixed name.