fix: make sure unpacked asar resources are still identified as APP_CODE #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR electron#124 introduced a regression where the following path: Contents/Resources/app.asar.unpacked/node_modules/fsevents/fsevents.node Would get identified as `AppFileType.MACHO` instead of `AppFileType.APP_CODE` as it was previously We need to make sure that path containing `.asar.unpacked/` are also treated as `APP_CODE`
mmaietta
reviewed
Apr 29, 2025
| if (p.endsWith('.asar')) { | ||
| // Need to match both e.g. `Contents/Resources/app.asar` and | ||
| // `Contents/Resources/app.asar.unpacked/node_modules/fsevents/fsevents.node` | ||
| if (p.endsWith('.asar') || p.includes('.asar.unpacked/')) { |
Contributor
There was a problem hiding this comment.
Left a comment on your original comment
#124 (comment)
Happy to continue the discussion here though!
Contributor
|
electron/universal fix has been merged and released under v2.0.3 You should be able to override the subdependency in your package.json until electron/universal is updated in electron/forge or electron-builder |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #124 introduced a regression where the following path:
Would get identified as
AppFileType.MACHOinstead ofAppFileType.APP_CODEas it was previouslyWe need to make sure that path containing
.asar.unpacked/are also treated asAPP_CODEOtherwise, universal native Node modules like
fsevents.nodeget passed to this check that results in the following error: