Skip to content

Update go to 1.25 across all Dockerfile definitions#3698

Merged
anoadragon453 merged 2 commits into
mainfrom
anoa/dockerfile_go_1_25_v2
May 20, 2026
Merged

Update go to 1.25 across all Dockerfile definitions#3698
anoadragon453 merged 2 commits into
mainfrom
anoa/dockerfile_go_1_25_v2

Conversation

@anoadragon453
Copy link
Copy Markdown
Member

These spots were missed in #3688. Found by looking at https://github.com/element-hq/dendrite/pull/3582/changes.

I've added some comments to avoid missing this again in the future.

Recommended to review commit-by-commit.

Pull Request Checklist

Signed-off-by: Andrew Morgan <andrewm@element.io>

@anoadragon453 anoadragon453 requested a review from a team as a code owner May 20, 2026 11:10
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.21%. Comparing base (933a12d) to head (678a35e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3698   +/-   ##
=======================================
  Coverage   52.21%   52.21%           
=======================================
  Files         524      524           
  Lines       48435    48435           
=======================================
+ Hits        25291    25292    +1     
- Misses      19626    19628    +2     
+ Partials     3518     3515    -3     
Flag Coverage Δ
unittests 52.21% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@anoadragon453
Copy link
Copy Markdown
Member Author

Not much to see here, so just going to merge.

cc @richvdh who reviewed the original PR; there were other spots apparently.

@anoadragon453 anoadragon453 merged commit 08cac1c into main May 20, 2026
34 of 37 checks passed
@anoadragon453 anoadragon453 deleted the anoa/dockerfile_go_1_25_v2 branch May 20, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants