Implement unstable support for MSC4472#33506
Draft
timedoutuk wants to merge 2 commits into
Draft
Conversation
Signed-off-by: timedout <git@nexy7574.co.uk>
Half-Shot
reviewed
May 15, 2026
Member
Half-Shot
left a comment
There was a problem hiding this comment.
Couple of things to get you started
| @@ -2149,7 +2149,7 @@ | |||
| "upgrade_error_title": "Chyba při aktualizaci místnosti", | |||
Member
There was a problem hiding this comment.
So this is a rule that trips everyone up, but we don't edit non-english translations in PRs. You just edit en_EN.json and folks will kindly update the other translations through Localazy.
| @@ -14,9 +14,11 @@ import { _t } from "../../../languageHandler"; | |||
| import RoomUpgradeDialog from "../dialogs/RoomUpgradeDialog"; | |||
Member
There was a problem hiding this comment.
A playwright test would be good to see this in action! https://github.com/element-hq/element-web/blob/develop/apps/web/playwright/e2e/room/room-status-bar.spec.ts#L29 is probably a good starting point. I would create a new test file for room upgrades, mock out the capabilities response to contain your new field, create a room with a deprecated version, and test that the banner appears.
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements special handling for
deprecatedroom types, presenting a marginally different warning banner when a deprecated room type is in use (uses "end-of-life" for deprecated rooms instead of blanket "unstable")Depends on matrix-org/matrix-js-sdk#5326
Note that while the i18n templates have all been updated, the English words
end-of-lifeandunstableare now constants. Unfortunately I am unable to reliably translate these terms into all of the supported languages.Checklist
public/exportedsymbols have accurate TSDoc documentation.