Skip to content

Implement unstable support for MSC4472#33506

Draft
timedoutuk wants to merge 2 commits into
element-hq:developfrom
timedoutuk:tmedoutuk/msc4472
Draft

Implement unstable support for MSC4472#33506
timedoutuk wants to merge 2 commits into
element-hq:developfrom
timedoutuk:tmedoutuk/msc4472

Conversation

@timedoutuk
Copy link
Copy Markdown

Implements special handling for deprecated room types, presenting a marginally different warning banner when a deprecated room type is in use (uses "end-of-life" for deprecated rooms instead of blanket "unstable")

Depends on matrix-org/matrix-js-sdk#5326

Note that while the i18n templates have all been updated, the English words end-of-life and unstable are now constants. Unfortunately I am unable to reliably translate these terms into all of the supported languages.

Checklist

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 15, 2026

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions Bot added the Z-Community-PR Issue is solved by a community member's PR label May 15, 2026
Copy link
Copy Markdown
Member

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of things to get you started

@@ -2149,7 +2149,7 @@
"upgrade_error_title": "Chyba při aktualizaci místnosti",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is a rule that trips everyone up, but we don't edit non-english translations in PRs. You just edit en_EN.json and folks will kindly update the other translations through Localazy.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, fantastic

@@ -14,9 +14,11 @@ import { _t } from "../../../languageHandler";
import RoomUpgradeDialog from "../dialogs/RoomUpgradeDialog";
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A playwright test would be good to see this in action! https://github.com/element-hq/element-web/blob/develop/apps/web/playwright/e2e/room/room-status-bar.spec.ts#L29 is probably a good starting point. I would create a new test file for room upgrades, mock out the capabilities response to contain your new field, create a room with a deprecated version, and test that the banner appears.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Z-Community-PR Issue is solved by a community member's PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants