Simplify and speed up DeviceListener#33543
Draft
andybalaam wants to merge 6 commits into
Draft
Conversation
andybalaam
force-pushed
the
andybalaam/speed-up-devicelistener
branch
from
a52ae23 to
8c8883b
Compare
This will allow us to simplify the logic that calls it.
These are already known at the time of logging due to the surrounding logic.
andybalaam
force-pushed
the
andybalaam/speed-up-devicelistener
branch
from
8c8883b to
d9cf207
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Break up recheck into separate functions. The intervening commits are intended to make it easier to see that the code is correct - feel free to read them if it helps, or look at the full diff.
Part of https://github.com/element-hq/crypto-internal/issues/305
Depends on #32982
Checklist
public/exportedsymbols have accurate TSDoc documentation.