Apply danger button class to ConfirmRedactDialog#33601
Open
Can3299 wants to merge 2 commits into
Open
Conversation
|
|
github-actions
Bot
added
the
Z-Community-PR
ADD - `primaryButtonClass` prop to TextInputDialog CHANGE - Pass `primaryButtonClass="danger"` to TextInputDialog in ConfirmRedactDialog
Can3299
force-pushed
the
change-confirm-button-color
branch
from
e69a0e9 to
c7758c4
Compare
dbkr
reviewed
May 26, 2026
## ADD - TextInputDialog-test.tsx: full test suite covering title/description rendering, placeholder, button text, primaryButtonClass, cancel behavior, and hasCancel toggle ## CHANGE - ConfirmRedactDialog-test.tsx: add 4 rendering tests — danger button class, state event description, reason field presence, and onFinished call with reason
Author
I had thought that unit tests werent necessary for a change like this, but I've now added the tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADD
primaryButtonClassprop to TextInputDialogCHANGE
primaryButtonClass="danger"to TextInputDialog in ConfirmRedactDialogChecklist
public/exportedsymbols have accurate TSDoc documentation.Description:
Adds an optional primaryButtonClass prop to TextInputDialog that is forwarded to DialogButtons, allowing consumers to style the primary button. Uses this in ConfirmRedactDialog by passing "danger" so the "Remove" button in the redaction confirmation dialog is visually styled as a destructive action, making it clearer to users that the action cannot be easily undone.