Improve multi-screenshot composer workflow#33609
Draft
pmbemax wants to merge 2 commits into
Draft
Conversation
Stage pasted or dropped images in the composer, use the normal composer text as shared media context, and render same-send image batches as one coherent timeline group while preserving standard Matrix media events. Refs element-hq/element-meta#3231
Author
|
Note for maintainers: I do not have label permissions on this repository. The Preview Changelog check appears to require a changelog/type label; this should likely be |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This draft PR implements the full multi-screenshot composer workflow proposed in element-hq/element-meta#3231:
m.image) under the hood;This is opened as a draft because the product/design direction should be confirmed first. If maintainers prefer smaller review units, I can split the implementation into composer-side staging first and timeline grouping second while keeping the same product goal.
Why
Desktop users frequently paste/drop several screenshots while explaining a bug, support case, design review, or technical workflow. The explanation usually belongs to the whole screenshot set, not to each image independently.
This PR keeps the protocol-compatible media-event model while improving the sender and receiver UX in Element Web/Desktop.
Event compatibility
The implementation keeps sending standard
m.room.messagemedia events withmsgtype: "m.image".For same-send image batches, it adds an extra namespaced content object:
Clients that do not understand this key should continue to display normal media events. Element uses it only to group consecutive same-sender, same-batch image events in the timeline.
UI behavior
Tests run
Local verification on this branch:
Notes
Notes: Add a multi-screenshot composer workflow that stages pasted/dropped screenshots, uses the normal composer text as shared context, and groups same-batch screenshots in the timeline while preserving standard Matrix media events.