Skip to content

Fix non-urgent toast inline link being invisible on light theme #33632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
999purple999 wants to merge 1 commit into
base: develop
Choose a base branch
from
+10 −0
Draft

Fix non-urgent toast inline link being invisible on light theme #33632

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions apps/web/res/css/structures/_NonUrgentToastContainer.pcss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,15 @@ Please see LICENSE files in the repository root for full details.
/* in all themes. */
background-color: #17191c;
color: #fff;

/* Inline links inherit `--cpd-color-text-primary` from
* `_AccessibleButton.pcss`, which is theme-dependent — on light
* theme that is a dark colour, which is invisible against this
* container's hard-coded dark background. Pin the link colour to
* white so it stays readable in both themes, matching the
* container's intentional theme-independence noted above. */
.mx_AccessibleButton.mx_AccessibleButton_kind_link_inline {
color: #fff;
}
}
}
Loading