Skip to content

Fix broken app icon on debian dock #33635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
MidhunSureshR wants to merge 1 commit into
base: develop
Choose a base branch
from
+9 −0
Draft

Fix broken app icon on debian dock #33635

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions apps/desktop/electron-builder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,15 @@ const config: Omit<Writable<Configuration>, "electronFuses"> & {
category: "Network;InstantMessaging;Chat",
icon: "icon.png",
executableName: variant.name, // element-desktop or element-desktop-nightly
desktop: {
entry: {
// By default, electron builder will set this to variant.productName.
// But electron builder also sets the WM_CLASS of the window to variant.name.
// This difference will cause the app to launch with no icon and sometimes
// prevents app grouping in the taskbar.
Comment on lines +138 to +141
Copy link
Copy Markdown
Member

@t3chguy t3chguy May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an upstream issue? That sounds like a bug

Copy link
Copy Markdown
Member Author

@MidhunSureshR MidhunSureshR May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An issue was created (electron-userland/electron-builder#4974) but it doesn't look like it received any attention.

Copy link
Copy Markdown
Member

@t3chguy t3chguy May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be worth including that link in the comment for future devs

Copy link
Copy Markdown
Member Author

@MidhunSureshR MidhunSureshR May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More recent: electron-userland/electron-builder#9103

Copy link
Copy Markdown
Member Author

@MidhunSureshR MidhunSureshR May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm.. looks like that issue also provides a different solution for this i.e the app-id is element-nightly but the desktop file is named element-desktop-nightly.desktop. If i rename the desktop file to element-nightly.desktop, the icon issue is fixed.

Copy link
Copy Markdown
Member

@t3chguy t3chguy May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be a bit odd to install element-desktop-nightly and then the desktop file is called something else

Copy link
Copy Markdown
Member

@t3chguy t3chguy May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the point it raises re Wayland is one that this PR does not solve

StartupWMClass: variant.name,
},
},
},
deb: {
packageCategory: "net",
Expand Down
Loading