Show preview when sharing media from intent

[bxdxnn]

Content

Motivation and context

Fixes #6540
Fixes #2987

Screenshots / GIFs

Tests

• Share a media using the Android sharing intent

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• This PR was made with the help of AI:
  • Yes. In this case, please request a review by Copilot.
  • No.
• Changes have been tested on an Android device or Android emulator with API 24
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request title will be used in the release note, it clearly defines what will change for the user
• Pull request includes screenshots or videos if containing UI changes
• You've made a self review of your PR

[github-actions]

Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:

• If your pull request adds a feature or modifies the UI, this should have an equivalent pull request in the Element X iOS repo unless it only affects an Android-only behaviour or is behind a disabled feature flag, since we need parity in both clients to consider a feature done. It will also need to be approved by our product and design teams before being merged, so it's usually a good idea to discuss the changes in a Github issue first and then start working on them once the approach has been validated.
• Your branch should be based on origin/develop, at least when it was created.
• The title of the PR will be used for release notes, so it needs to describe the change visible to the user.
• The test pass locally running ./gradlew test.
• The code quality check suite pass locally running ./gradlew runQualityChecks.
• If you modified anything related to the UI, including previews, you'll have to run the Record screenshots GH action in your forked repo: that will generate compatible new screenshots. However, given Github Actions limitations, it will prevent the CI from running temporarily, until you upload a new commit after that one. To do so, just pull the latest changes and push an empty commit.

[frebib]

Note that this also adds closer parity with iOS too

[bxdxnn]

Note that this also adds closer parity with iOS too

Good! What's the preview/send order in iOS?

[frebib]

Note that this also adds closer parity with iOS too

Good! What's the preview/send order in iOS?

On the iPad we have it's user selection then preview

[bmarty]

Thanks. We already have a media preview screen, but it is in the :features:messages:impl module. Maybe a first step would be to extract this existing code to its own module and then reuse it. It has more features, and it will reduce code duplication.

[bxdxnn]

Thanks. We already have a media preview screen, but it is in the :features:messages:impl module. Maybe a first step would be to extract this existing code to its own module and then reuse it. It has more features, and it will reduce code duplication.

Is it required for this PR? It seems to be very complex to fully extract that functionality then share it, or do you want to only extract the View?

[bmarty]

Thanks. We already have a media preview screen, but it is in the :features:messages:impl module. Maybe a first step would be to extract this existing code to its own module and then reuse it. It has more features, and it will reduce code duplication.

Is it required for this PR? It seems to be very complex to fully extract that functionality then share it, or do you want to only extract the View?

Ideally yes. Maybe do a separate PR that just extract the code with the Preview to its own api / impl module. The messages module is too big anyway. Moreover, features like editing image before sending would land to the new :features:mediapreview:impl module. I can take a quick look on how hard this could be.

[mxandreas]

FWIW, on iOS the preview screen to enter the caption is always shown.

When sharing, there are 2 paths:

1. You can immediately select a DM or a room from the OS share sheet (it is populated with the most frequent/recent ones across your different apps, e.g. Element, WhatsApp, etc.). In this case you do not need any further DM/room selection.
2. You can also just choose the app, in which case EXI will provide the user with a list of rooms to choose from. See screenshot below.

(It seems like this is very similar on Android as well, although I could not test path #1 as the OS did not offer any Element chats, perhaps because I haven't used it frequently).

[bxdxnn]

(It seems like this is very similar on Android as well, although I could not test path #1 as the OS did not offer any Element chats, perhaps because I haven't used it frequently).

This is implemented in #6059 but not merged yet.

[bxdxnn]

I've fully moved the media preview into it's own module in the last pushes, is there anything else that needs to be done before merging?