Bump kotlinx.collections.immutable to 0.5.0-beta01#6788
Open
DmitryNekrasov wants to merge 1 commit into
Open
Conversation
Applied via kotlin-tooling-immutable-collections-0-5-0-migration skill. 0.5.0-beta01 is binary-compatible with 0.4.0; per KEEP-0459 the copy-returning methods on Persistent* types are renamed (e.g. add->adding, remove->removing) and the old names remain as @deprecated(WARNING) overloads. element-x-android uses the library as a read-only consumer (persistentListOf -> ImmutableList<T> typed values, no in-place mutation via Persistent* receivers), so the compiler emits zero deprecation warnings post-bump and no call sites need to be renamed. See MIGRATION_REPORT.md for per-phase details. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:
|
2 tasks
Author
|
Hi @ganfra — quick heads-up: this PR came out of testing a Claude Code skill I'm building for migrating Kotlin projects to kotlinx.collections.immutable 0.5.x (Kotlin/kotlin-agent-skills#45), so element-x-android was a real-world OSS testbed for a read-only consumer. No production urgency — happy to wait for the stable 0.5.0 release before merging. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
kotlinx.collections.immutablefrom 0.4.0 to 0.5.0-beta01.0.5.0-beta01 is binary-compatible with 0.4.0 — per KEEP-0459, the copy-returning methods on
Persistent*types were renamed (e.g.add→adding,remove→removing), and the old names remain as@Deprecated(WARNING)overloads. So this PR is purely a version bump and is reversible.Why no source changes?
element-x-android uses
kotlinx.collections.immutableas a read-only consumer —persistentListOf(...)etc. as factories, with values typed everywhere asImmutableList<T>/ImmutableMap<K, V>/ImmutableSet<T>(the read-only interfaces). None of the renamed methods onPersistent*are visible at any call site, so the Kotlin compiler emits zerokotlinx.collections.immutabledeprecation warnings after the bump.Scope checks:
Persistent(List|Map|Set|Collection)<…>..mutate { }call (inIncomingVerificationStateMachine.kt) is a state-machine helper, not the kotlinx extension.Changes
gradle/libs.versions.toml:kotlinx_collections_immutable = "…:0.4.0"→"…:0.5.0-beta01".MIGRATION_REPORT.md: per-phase audit (happy to drop this if you'd prefer to keep the repo root tidy).References
Test plan
:app(Gplay + Fdroid debug, main + UnitTest) pluscompileDebugUnitTestKotlinacross all ~200 subprojects —BUILD SUCCESSFUL in 4m 58s(4939 tasks), zerokotlinx.collections.immutabledeprecation warnings.:libraries:recentemojis:impl:testDebugUnitTest,:libraries:usersearch:impl:testDebugUnitTest,:features:roomcall:impl:testDebugUnitTest— all pass.🤖 Generated with Claude Code