Replace Twisted with aiohttp and native asyncio#628
Draft
sandhose wants to merge 8 commits into
Draft
Conversation
fd90959 to
9f02890
Compare
b4968f6 to
75c3d27
Compare
9f02890 to
25a9496
Compare
75c3d27 to
07ba146
Compare
25a9496 to
e9d5495
Compare
07ba146 to
6e4f741
Compare
6e4f741 to
ba57ad6
Compare
e9d5495 to
8cff64d
Compare
ba57ad6 to
e6e33bc
Compare
8cff64d to
004fd70
Compare
e6e33bc to
5bebdec
Compare
004fd70 to
13aa531
Compare
13aa531 to
303eca6
Compare
5bebdec to
0e548d7
Compare
303eca6 to
70d6161
Compare
0e548d7 to
5c4a7a6
Compare
70d6161 to
79ecbe6
Compare
5c4a7a6 to
3983f5e
Compare
79ecbe6 to
8c52197
Compare
3983f5e to
0d35a03
Compare
aa731f6 to
c7d0c49
Compare
c7d0c49 to
39e3169
Compare
ddd42cc to
377e703
Compare
39e3169 to
f94d19f
Compare
377e703 to
03c779e
Compare
f94d19f to
8512068
Compare
7a17ecc to
ef43607
Compare
ef43607 to
065d1af
Compare
065d1af to
24a43cf
Compare
03c779e to
f63c9b1
Compare
24a43cf to
81d4bea
Compare
f63c9b1 to
239747c
Compare
Replace twisted, zope.interface, mypy-zope with aiohttp, dnspython, pytest stack. Rewrite servlets/__init__.py with aiohttp middleware patterns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resource/Site) withaiohttp.webAgent) withaiohttp.ClientSessiontwisted.namesSRV resolution withdnspythonreactor.run()withasyncio.run()LoopingCallwithasyncio.create_task()+ sleep loopstrialtopytest+pytest-asyncioKnown limitations
pyOpenSSLkept for replication peer cert CN extractiontest_bind_notYourMxidmay be flaky due to aiosmtpd startup race in integration testsTest plan
uv run pytest tests/— 100 tests passuv run pytest --pyargs matrix_is_tester— 37/37 passuv run mypy— no errorstwistedorzope.interfaceimports remain