Suppress raw JSON logs in Complement CI when debug disabled.#19745
Suppress raw JSON logs in Complement CI when debug disabled.#19745reivilibre wants to merge 3 commits into
Conversation
MadLittleMods
left a comment
MadLittleMods
left a comment
There was a problem hiding this comment.
(didn't review change, only comment)
| @@ -122,12 +123,26 @@ jobs: | |||
| # -json: Output JSON format so that gotestfmt can parse it. | |||
| # | |||
There was a problem hiding this comment.
My vote would be to leave it as-is.
Although, I don't run into problems when viewing the logs now that the formatted view only shows failures.
And re-running with debug logging is another step when I want to see the output which I've wanted to multiple times recently:
- Wanting to see if a new test is actually being run
- Figuring out why
gotestfmtwas failing
On top of it generally being useful of the CI job making progress.
There was a problem hiding this comment.
Yep, happy to leave it in if this is something you rely on, by all means this PR was just a convenient place to put that question.
Would be curious if there are other ideas to make this less unbearable.
Suppose we could upload the formatted fail-only logs as a downloadable artifact? Feels like 'a workaround' but one I'm happy to take. Thoughts?
There was a problem hiding this comment.
I was trying to debug some flakes and the webUI to get the logs was just so sluggish.
Viewing this page is laggy? (with only the Formatted Complement test logs (only failing are shown) section expanded) https://github.com/element-hq/synapse/actions/runs/25128863747/job/73673674666
You can expand the ❌ section to see the logs for the test.
GitHub's fake scroll doesn't help with being able to copy-paste everything easily but I don't experience any problems outside of that. The failed section is 19k lines by itself (55k lines total for the entire raw log of the CI job) which is a lot to manage regardless of what we do.
Perhaps some GitHub extension you're using is making it worse than usual?
I tried to download the log file and the download got interrupted, presumably because of the size.
Multiple attempts did not help and it was not resumable.
The raw logs also download fine for me. It's only 16.5MB. You can see that I also did that when figuring out why gotestfmt was failing to archive the logs
upload the formatted fail-only logs as a downloadable artifact
Additionally having GitHub workflow artifacts of whatever logs sounds fine to me.
| # To see the full build log, start a re-run with | ||
| # the debug mode enabled in the GitHub UI. |
There was a problem hiding this comment.
To make this more clear, to accomplish this, when viewing a CI job, Re-run all jobs -> Scroll down to Enable debug logging and check it -> Re-run jobs
2 participants
I was trying to debug some flakes and the webUI to get the logs was just so sluggish.
I tried to download the log file and the download got interrupted, presumably because of the size.
Multiple attempts did not help and it was not resumable.
I don't like the ugly JSON logs (they don't seem useful to me); I'm somewhat sympathetic with it being nice
to see that it's doing something but from memory this is a vanishingly rare requirement for me.
If you need to see it, the best proposal I have is for you to re-run the workflow whilst ticking the 'debug mode' box,
which is what this PR suggests as the mechanism to get the live-streamed JSON log dump.
Open to alternative suggestions.