Skip to content

Conversation

@danirabbit
Copy link
Member

GTK4 prep and code style:

  • use SPDX header
  • Reduce variable scope and organize
  • rename glib settings show_weeks as settings
  • Menubutton use menu model directly instead of building a gtk.menu manually
  • Brackets with if
  • Explicit vertical and horizontal expands
  • Explicitly scope functions
  • get rid of single-use function to build the grid
  • Use a revealer to show/hide weeks header spacer and bind to show_weeks setting

@danirabbit danirabbit requested a review from a team January 20, 2026 21:44
@danirabbit danirabbit moved this to Needs Review in GTK4 Porting Jan 20, 2026
@danirabbit danirabbit enabled auto-merge (squash) January 28, 2026 15:14
@danirabbit danirabbit merged commit 770cb63 into master Jan 28, 2026
6 checks passed
@danirabbit danirabbit deleted the danirabbit/calendarview-gtk4prep branch January 28, 2026 15:20
@github-project-automation github-project-automation bot moved this from Needs Review to Done in GTK4 Porting Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants